Feature maya enter amount #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o/dash-wallet into feature-maya-integration-address
…into feature-maya-integration-address
HashEngineering
commented
Mar 25, 2024
| @@ -207,17 +236,11 @@ class AmountView(context: Context, attrs: AttributeSet) : ConstraintLayout(conte | |||
| binding.resultCurrencyToggle.isVisible = showCurrencySelector && dashToFiat | |||
|
|
|||
| if (dashToFiat) { | |||
| binding.inputSymbolDash.isVisible = isCurrencySymbolFirst | |||
| binding.inputSymbolDashPostfix.isVisible = !isCurrencySymbolFirst | |||
|
|
|||
There was a problem hiding this comment.
The symbol is now inserted into the Text Span, rather than being in a separate view.
HashEngineering
commented
Mar 25, 2024
| // } | ||
| // | ||
| // listOf() | ||
| // } |
There was a problem hiding this comment.
for now we will mock the result of the inbound_addresses api.
HashEngineering
commented
Mar 25, 2024
Comment on lines
+34
to
+38
| data class SwapTradeResponseData( | ||
| val fee: SwapApiAmount? = null, | ||
| val id: String? = null, | ||
| @SerializedName("applied_subscription_benefit") | ||
| val applied_subscription_benefit: Boolean? = null, |
There was a problem hiding this comment.
This class and many others were copied from Coinbase. We will delete them or modify them in the next stories.
Syn-McJ
approved these changes
Mar 25, 2024
| app:autoSizeMaxTextSize="48sp" | ||
| android:gravity="center" | ||
| android:layout_gravity="center|bottom" | ||
| app:sizeToFit="true" /--> |
There was a problem hiding this comment.
Correct, not needed.
integrations/maya/build.gradle
Outdated
| @@ -73,6 +73,9 @@ dependencies { | |||
| implementation "com.google.android.material:material:$materialVersion" | |||
| implementation "androidx.constraintlayout:constraintlayout:$constrainLayoutVersion" | |||
| implementation "androidx.swiperefreshlayout:swiperefreshlayout:$swipeRefreshLayoutVersion" | |||
| implementation "io.coil-kt:coil:$coilVersion" | |||
| implementation "androidx.browser:browser:$browserVersion" | |||
| implementation 'me.grantland:autofittextview:0.2.1' | |||
There was a problem hiding this comment.
AutofitTextView seems to be commented out, maybe we don't need this import
There was a problem hiding this comment.
Thanks, this will be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This interface is taken from the Coinbase integration and modified to meet the new designs.
Some Coinbase items remain and will be refactored or deleted in the next stories.
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: