Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(uphold): activate topper by reverting (#1186) #1203

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Sep 18, 2023

Issue being fixed or feature implemented

Enable Topper.

Related PR's and Dependencies

None.

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Comment on lines +103 to +106
lifecycleScope.launch {
val uri = viewModel.topperBuyUrl(getString(R.string.dash_wallet_name))
viewModel.logEvent(AnalyticsConstants.Topper.ENTER_UPHOLD)
requireActivity().openCustomTab(uri)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topperBuyUrl was changed to suspend

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering HashEngineering merged commit 282a1ec into master Sep 20, 2023
3 checks passed
@HashEngineering HashEngineering deleted the feature-topper-activate branch October 30, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants