Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(maya): add main maya entrypoint #1201

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Feat(maya): add main maya entrypoint #1201

merged 6 commits into from
Sep 15, 2023

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

Add Maya Entry Points

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Sep 12, 2023
@HashEngineering HashEngineering changed the title Feature maya entrypoint Feat(maya): add main maya entrypoint Sep 13, 2023
@HashEngineering HashEngineering marked this pull request as ready for review September 14, 2023 04:37
Syn-McJ
Syn-McJ approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however when more work is done on the viewModel, it's better to replace LiveData with flows as we discussed (see uiState in the UpholdViewModel).

@HashEngineering HashEngineering merged commit 0d0d9b2 into feature-maya Sep 15, 2023
3 checks passed
@HashEngineering HashEngineering deleted the feature-maya-entrypoint branch September 15, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @Syn-McJ