Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Finer control of dashd_debug and drive debugging #666

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

ktechmidas
Copy link
Contributor

@ktechmidas ktechmidas commented Sep 23, 2024

Issue being fixed or feature implemented

Individual control of a node's debug level, there are 3 options we can add under a node now:

  • dashd_debug (can be set to 0 or 1)
  • drive_debug (can be set to 0 or 1, it will use the corresponding debug image of drive and enable visualizer on nodes with debug on)
  • tenderdash_debug (passed straight to tenderdash, ie info, debug, trace)

What was done?

Changed dashmate template to use additional vars from the yml file

How Has This Been Tested?

Testnet on devnet

Breaking Changes

None, if these vars are not defined it will use global vars as before. This PR is backwards compatible

Checklist:

  • [ x] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have added or updated relevant unit/integration/functional/e2e tests
  • [x ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ktechmidas ktechmidas merged commit 3e881f0 into v1.0-dev Sep 23, 2024
1 check passed
@ktechmidas ktechmidas deleted the fix/make_debugging_great_again branch September 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants