feat: Add custom reactions to ReactionKind for posts #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siman
requested changes
May 31, 2023
| @@ -33,6 +33,7 @@ pub type ReactionId = u64; | |||
| pub enum ReactionKind { | |||
| Upvote, | |||
| Downvote, | |||
| Custom(u32), | |||
There was a problem hiding this comment.
Maybe call it Emoji?
But I am not sure, need to discuss it.
There was a problem hiding this comment.
I remember one idea was to support custom reactions (not even emojis).
For example, you could use custom reactions to implement on-chain voting, and having 4 bytes can give you a lot of variations for different options in a poll.
| @@ -78,6 +78,7 @@ benchmarks! { | |||
| let other_kind = match reaction.kind { | |||
| ReactionKind::Upvote => ReactionKind::Downvote, | |||
| ReactionKind::Downvote => ReactionKind::Upvote, | |||
| _ => ReactionKind::Upvote, | |||
There was a problem hiding this comment.
I am not sure about this. What if this is a negative emoji? Then it cannot be considered as an upvote.
F3Joule
added
enhancement
F3Joule
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.