Create scorecard.yml #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create scorecard workflow. Doc-only: true. Signed-off-by: Tomasz Gromadzki <[email protected]>
brianjmurrell
requested changes
Sep 3, 2024
| - cron: '17 9 * * 1' | ||
| push: | ||
| branches: [ "master" ] | ||
|
|
There was a problem hiding this comment.
We should add pull_request: here so that issues are found in PRs, not once they have landed to master.
Suggested change
| pull_request: | |
There was a problem hiding this comment.
Done, however, it does not make big sense as the scorecard dose does not produce yes/no judgement
There was a problem hiding this comment.
IIRC, it does flag errors that are found. You could try introducing one and confirm.
.github/workflows/scorecard.yml
Outdated
| branches: [ "master" ] | ||
|
|
||
| # Declare default permissions as read only. | ||
| permissions: read-all |
There was a problem hiding this comment.
Is read permission needed here? The DAOS version of this workflow uses:
permissions: {}
and AFAICT seems to be functioning correctly, but maybe I am missing something.
Doc-only: true Signed-off-by: Tomasz Gromadzki <[email protected]>
Doc-only: true Signed-off-by: Tomasz Gromadzki <[email protected]>
brianjmurrell
requested changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create scorecard workflow.
Doc-only: true.