Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore patches after upstream fixes #15427

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Restore patches after upstream fixes #15427

merged 6 commits into from
Nov 1, 2024

Conversation

jolivier23
Copy link
Contributor

@jolivier23 jolivier23 commented Oct 29, 2024

Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Restore

@jolivier23 jolivier23 force-pushed the jvolivie/merge branch 2 times, most recently from ad78eb1 to e28b825 Compare October 30, 2024 19:08
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15427/3/execution/node/1135/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15427/3/execution/node/1169/log

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15427/4/execution/node/1145/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15427/4/execution/node/1203/log

Required-githooks: true

Change-Id: I10ac4c7b9cc674167a40c6b92014f58acf33de72
Signed-off-by: Jeff Olivier <[email protected]>
Release branch PRs should use the release branch build
instead of master branch build for NLT reference

Signed-off-by: Jeff Olivier <[email protected]>
Release branch PRs should use the release branch build
instead of master branch build for Fault Injection reference

Signed-off-by: Jeff Olivier <[email protected]>
debian and rpm packages need to depend on mercury 2.4+

Required-githooks: true

Change-Id: If5670dba6a6d30a04804736ef9da2de90c3347f3
Signed-off-by: Jeff Olivier <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15427/5/execution/node/346/log

)

* DAOS-14408 common: enable NDCTL for DCPM

This PR prepares DAOS to be used with NDCTL enabled in PMDK, which means:
- NDCTL must not be used when non-DCPM (simulate PMem) - `storage class: "ram"` is used:
`PMEMOBJ_CONF=sds.at_create=0` env variable disables NDCTL features in the PMDK
This change affects all tests run on simulated PMem (e.g. inside VMs).
Some DOAS utility applications may also require `PMEMOBJ_CONF=sds.at_create=0` to be set.

- The default ULT stack size must be at least 20KiB to avoid stack overuse by PMDK with NDCTL enabled and be aligned with Linux page size.
`ABT_THREAD_STACKSIZE=20480` env variable is used to increase the default ULT stack size.
This env variable is set by control/server module just before engine is started.
Much bigger stack is used for pmempool open/create-related tasks e.g. `tgt_vos_create_one` to avoid stack overusage.

This modification shall not affect md-on-ssd mode as long as `storage class: "ram"` is used for the first tier in the `storage` configuration.
This change does not require any configuration changes to existing systems.

The new PMDK package with NDCTL enabled (daos-stack/pmdk#38) will land as soon as this PR is merged.

Change-Id: If4c3f7d88a97e4e4f5526da71f4b374a2844057b
Signed-off-by: Jan Michalski <[email protected]>
Copy link
Contributor

@cdavis28 cdavis28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see new libraries. Is this going to be a repeat of pci drivers?

Copy link
Contributor

@cdavis28 cdavis28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we need to worry about the drivers when it's merged into GOB.

@jolivier23
Copy link
Contributor Author

I see new libraries. Is this going to be a repeat of pci drivers?

Unfortunately, probably. I don't see a good way around this. We can avoid taking the pmdk update (which is really removing all stuff we don't need from pmdk) but we will want it eventually, I think

@jolivier23 jolivier23 merged commit 46b5d32 into google/2.6 Nov 1, 2024
68 of 73 checks passed
@jolivier23 jolivier23 deleted the jvolivie/merge branch November 1, 2024 20:29
@wangdi1 wangdi1 self-requested a review November 1, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants