Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/2.6 Acceptance Branch #15390

Draft
wants to merge 12 commits into
base: release/2.6
Choose a base branch
from
Draft

Release/2.6 Acceptance Branch #15390

wants to merge 12 commits into from

Conversation

mjean308
Copy link
Contributor

release 2.6 plus

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

frostedcmos and others added 7 commits October 24, 2024 12:12
@frostedcmos @mjean308
DAOS-15914: crt_reply_send_input_free()
0473884 
- New crt_reply_send_input_free() API added which releases input buffer right
  after HG_Respond() instead of waiting until the handle is destroyed.

- srv_obj.c calls changed to use new crt_reply_send_input_free()

Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
@gnailzenh @mjean308
DAOS-15914: I/O context takes refcount on RPC
05ab8b3 
- I/O context takes refcount on RPC
- only release input buffer for target update

Signed-off-by: Liang Zhen <[email protected]>
@gnailzenh @mjean308
DAOS-15914: release input buffer earlier for dtx commit
93bcf2e 
Signed-off-by: Liang Zhen <[email protected]>
@daltonbohning @mjean308
DAOS-623 build: mercury remove mr match
3d1088b 
Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@Nasf-Fan @mjean308
DAOS-16469 container: Lower log level for cont_aggregate_interval
c0114c6 
To reduce the side-effect caused by frequent log with -DER_INPROGRESS.

Allow-unstable-test: true

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan @mjean308
DAOS-16721 object: fix coll RPC for obj with sparse layout - b26
d398f8b 
The old implementation did not correctly calculate some collective
object RPC size, and may cause trouble when need bulk data transfer
for large collective object RPC. It also potentially affects how to
dispatch collective RPCs from leader to other engines.

The patch also addes more sanity check for coll-punch RPC to detect
potential DRAM corruption.

Allow-unstable-test: true

Signed-off-by: Fan Yong <[email protected]>
@wiliamhuang @mjean308
DAOS-16722 client: to intercept PMPI_Init() in libpil4dfs
ef7d5aa 
Features: pil4dfs

Required-githooks: true
Skipped-githooks: codespell

Signed-off-by: Lei Huang <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15390/1/execution/node/329/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15390/1/execution/node/368/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15390/1/execution/node/362/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15390/1/execution/node/363/log

@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Release/2.6

daltonbohning
daltonbohning reviewed Oct 24, 2024
View reviewed changes
utils/build.config Outdated
Comment on lines 32 to 37
<<<<<<< HEAD
mercury=https://raw.githubusercontent.com/daos-stack/mercury/f3dc286fb40ec1a3a38a2e17c45497bc2aa6290d/na_ucx.patch
pmdk=https://github.com/pmem/pmdk/commit/2abe15ac0b4eed894b6768cd82a3b0a7c4336284.diff
=======
mercury=https://raw.githubusercontent.com/daos-stack/mercury/f3dc286fb40ec1a3a38a2e17c45497bc2aa6290d/na_ucx.patch,https://raw.githubusercontent.com/daos-stack/daos/refs/heads/dbohning/daos-623-disable-mr-match/mercury_remove_mr_match.patch
>>>>>>> a1ae676eb2 (DAOS-623 build: mercury remove mr match)
Copy link
Contributor

@daltonbohning daltonbohning Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<<<<<<< HEAD
mercury=https://raw.githubusercontent.com/daos-stack/mercury/f3dc286fb40ec1a3a38a2e17c45497bc2aa6290d/na_ucx.patch
pmdk=https://github.com/pmem/pmdk/commit/2abe15ac0b4eed894b6768cd82a3b0a7c4336284.diff
=======
mercury=https://raw.githubusercontent.com/daos-stack/mercury/f3dc286fb40ec1a3a38a2e17c45497bc2aa6290d/na_ucx.patch,https://raw.githubusercontent.com/daos-stack/daos/refs/heads/dbohning/daos-623-disable-mr-match/mercury_remove_mr_match.patch
>>>>>>> a1ae676eb2 (DAOS-623 build: mercury remove mr match)
mercury=https://raw.githubusercontent.com/daos-stack/mercury/f3dc286fb40ec1a3a38a2e17c45497bc2aa6290d/na_ucx.patch,https://raw.githubusercontent.com/daos-stack/daos/refs/heads/dbohning/daos-623-disable-mr-match/mercury_remove_mr_match.patch

@mjean308
fix comments
82416e3 
Signed-off-by: Maureen Jean <[email protected]>
@mjean308
fix build.config
d1d96e9 
Signed-off-by: Maureen Jean <[email protected]>
@mjean308
Merge branch 'release/2.6' into mjean/release/2.6/acceptance
3f24dab 
Required-githooks: true
@mjean308
release build
bd5b735 
faults-enabled: false

Required-githooks: true

Signed-off-by: Maureen Jean <[email protected]>
@mjean308
Merge branch 'release/2.6' into mjean/release/2.6/acceptance
08058e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@sylviachanoiyee sylviachanoiyee Awaiting requested review from sylviachanoiyee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mjean308 @daosbuild1 @daltonbohning @frostedcmos @gnailzenh @Nasf-Fan @wiliamhuang