Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15774 test: fix nvme/enospace.py container destroy #14285

Merged
merged 1 commit into from
May 3, 2024

Conversation

daltonbohning
Copy link
Contributor

Test-tag: NvmeEnospace
Skip-unit-tests: true
Skip-fault-injection-test: true

Track containers created with start_ior_load and delete them explicitly.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

Ticket title is 'security/pool_acl.py, pool_groups.py test fails due container destroy failure during the teardown state.'
Status is 'In Progress'
Labels: 'ci_impact,weekly_test'
https://daosio.atlassian.net/browse/DAOS-15774

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14285/2/execution/node/904/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14285/3/execution/node/903/log

@daltonbohning
Copy link
Contributor Author

Test passed with skipping register_cleanup:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14285/4/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15774-enospace branch 3 times, most recently from 4333bab to c0688c7 Compare May 2, 2024 19:01
Skip container destroy during teardown since these tests handle destroy
manually.

Test-tag: NvmeEnospace NvmePoolCapacity IorSmall
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning marked this pull request as ready for review May 3, 2024 13:39
@daltonbohning daltonbohning requested review from a team as code owners May 3, 2024 13:39
@daltonbohning
Copy link
Contributor Author

Modified test passed, and arbitrarily IorSmall for shared utility verification:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14285/8/testReport/

@daltonbohning daltonbohning requested a review from a team May 3, 2024 13:42
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 3, 2024
@daltonbohning daltonbohning merged commit 9a1b288 into master May 3, 2024
43 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-15774-enospace branch May 3, 2024 13:45
phender added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants