Merge pull request #1646 from danskernesdigitalebibliotek/DDFHER-99-o…

…pening-hours-modal-fails

DDFHER-99 - Fix issue caused by preserved opening hours referencing deleted branches

web/modules/custom/dpl_opening_hours/src/Model/OpeningHoursRepository.php

@@ -93,7 +93,10 @@ public function loadMultiple(int $branchId = NULL, \DateTimeInterface $fromDate
  }
  }, $result->fetchAll(\PDO::FETCH_ASSOC));
 
- return array_filter($possible_objects);
+ // Using array_values to reindex the array after filtering out NULL values.
+ // This is necessary because we don't handle the deletion of opening hour
+ // instances that reference a branch which has been deleted.
+ return array_values(array_filter($possible_objects));
  }
 
  /**