Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained actions-rs/cargo action in CI workflow #108

Closed
wants to merge 1 commit into from
Closed

Replace unmaintained actions-rs/cargo action in CI workflow #108

wants to merge 1 commit into from

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Mar 9, 2023

Basically all of the actions-rs/* actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/dalek-cryptography/x25519-dalek/actions/runs/4205824089:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

To get rid of those warnings the occurrences of actions-rs/cargo are replaced by direct invocations of cargo.

@tarcieri
Copy link
Contributor

@striezel you'll want to target the release/2.0 branch (which we should really merge into main)

@striezel
Replace unmaintained actions-rs/cargo action in CI workflow
21f44f2 
Basically all of the `actions-rs/*` actions are unmaintained. See
<actions-rs/toolchain#216> for more
information. Due to their age they generate several warnings in
CI runs.

To get rid of those warnings the occurrences of `actions-rs/cargo`
are replaced by direct invocations of `cargo`.
@striezel striezel changed the base branch from main to release/2.0 March 12, 2023 18:23
@striezel
Copy link
Contributor Author

@striezel you'll want to target the release/2.0 branch (which we should really merge into main)

Alright, I've re-applied the changes on top of release/2.0 and switched the base branch to release/2.0.

@tarcieri
Copy link
Contributor

@striezel can you rebase one more time now that #109 is merged?

@pinkforest
Copy link
Contributor

pinkforest commented Mar 12, 2023 •
edited
Loading

We don't really have any of these anymore as this was superceded by #109 as it was completely replaced workflow

Can be closed - we probably should merge to main after we get the current PRs in tracking here:

@striezel
Copy link
Contributor Author

@striezel can you rebase one more time now that #109 is merged?

As @pinkforest already said, the current workflows after the merge of #109 do not use actions-rs/cargo anymore, so I will close this.

my_job_here_is_done

😆

Just focus on getting the changes from release/2.0 to main and I'll be happy to see the actions-rs/cargo stuff vanish from the main branch, too.

@striezel striezel closed this Mar 12, 2023
@striezel striezel deleted the actions-rs-cargo-replacement branch March 12, 2023 22:43
@pinkforest
Copy link
Contributor

pinkforest commented Mar 12, 2023 •
edited
Loading

Hey thanks for all your help - we should get it in main soonish partying_face purple_heart

btw if you have some spare cycles, wanna help update https://github.com/rustsec/audit-check ? ❤️

@striezel
Copy link
Contributor Author

btw if you have some spare cycles, wanna help update https://github.com/rustsec/audit-check ? ❤️

I can try it, but don't get your hopes up, because I've never written a GitHub Action myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@striezel @tarcieri @pinkforest