Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at implementing streaming verification #303

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Monadic-Cat
Copy link

As requested here, this PR contains my port of PR #196 to use the hazmat module instead of implementing any cryptographic stuff itself.

I haven't copied over the added test yet, but I have confirmed basic functionality by test using it in a demo application I have lying around.

@tarcieri
Copy link
Contributor

Thanks for pushing this up. It's interesting you managed to make it work but I guess I misjudged whether this would be a good fit. Feels like the wrong abstraction level.

Perhaps VerifyingKey::recompute_R can be subdivided into some smaller functions (that is to say, preserve recompute_R, but have it call some other functions) which are more amenable to this streaming verification use case.

e.g. recompute_R_from_k?

@@ -0,0 +1,172 @@
use crate::{SignatureError, VerifyingKey};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this module could be src/verifying/streaming.rs?

@tarcieri
Copy link
Contributor

Looks like @robjtede updated #196 so perhaps we should continue the discussion there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants