Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do byte comparison in all verify_* functions #269

Merged
merged 4 commits into from
Jan 21, 2023
Merged

Do byte comparison in all verify_* functions #269

merged 4 commits into from
Jan 21, 2023

Conversation

rozbb
Copy link
Contributor

@rozbb rozbb commented Jan 20, 2023

This is just cleanup. As explained in #267, this doesn't change validation criteria.

This also removes manual clamping from this crate and uses curve25519_dalek::Scalar::from_bits_clamped instead, now that dalek-cryptography/curve25519-dalek#498 has landed.

@rozbb rozbb requested a review from tarcieri January 20, 2023 21:24
rozbb
rozbb commented Jan 21, 2023
View reviewed changes
src/signature.rs Outdated Show resolved Hide resolved
@rozbb rozbb merged commit c2b8978 into dalek-cryptography:release/2.0 Jan 21, 2023
@rozbb
Copy link
Contributor Author

rozbb commented Jan 21, 2023

Note: release/2.0 build is failing because ed25519 v2.0 was yanked. Rather than modifying Cargo.toml I'm just gonna wait until 2.0.1 comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rozbb @tarcieri