daedalean-assignment-operators: report location of base if available

daedaleanai · Aug 11, 2022 · 8a86e23 · 8a86e23
1 parent 63f720f
commit 8a86e23
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/clang-tools-extra/clang-tidy/daedalean/AssignmentOperatorsCheck.cpp b/clang-tools-extra/clang-tidy/daedalean/AssignmentOperatorsCheck.cpp
@@ -36,13 +36,25 @@ void AssignmentOperatorsCheck::check(const MatchFinder::MatchResult &Result) {
   }
 
   if (!MatchedDecl->hasUserDeclaredCopyAssignment()) {
-    diag(MatchedDecl->getBeginLoc(),
+    auto SourceLocation = MatchedDecl->getBeginLoc();
+
+    if (!MatchedDecl->bases().empty()) {
+      SourceLocation = MatchedDecl->bases_begin()->getBeginLoc();
+    }
+
+    diag(SourceLocation,
          "Non-abstract class %0 must implement copy-assignment operator")
         << MatchedDecl;
   }
 
   if (!MatchedDecl->hasUserDeclaredMoveAssignment()) {
-    diag(MatchedDecl->getBeginLoc(),
+    auto SourceLocation = MatchedDecl->getBeginLoc();
+
+    if (!MatchedDecl->bases().empty()) {
+      SourceLocation = MatchedDecl->bases_begin()->getBeginLoc();
+    }
+
+    diag(SourceLocation,
          "Non-abstract class %0 must implement move-assignment operator")
         << MatchedDecl;
   }