Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support RN0.49 #75

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

support RN0.49 #75

wants to merge 4 commits into from

Conversation

windwang
Copy link

No description provided.

@mikaello
Copy link

I don't think this will be merged, it hasn't been any activity in this repo since 5 Jul 2016. The fork react-native-modal-selector is RN 0.49 compatible.

Copy link

@recs182 recs182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this approach to fix this problem in packages like rc-maps and rc-fbsdk and I thinks it`s more interesting.

// if ViewPropTypes is not defined fall back to View.propType (to support RN < 0.44)
const viewPropTypes = ViewPropTypes || View.propTypes;

const propTypes = {
    data: PropTypes.array,
    onChange: PropTypes.func,
    initValue: PropTypes.string,
    style: viewPropTypes.style,
    selectStyle: viewPropTypes.style,
    optionStyle: viewPropTypes.style,
    optionTextStyle: Text.propTypes.style,
    sectionStyle: viewPropTypes.style,
    sectionTextStyle: Text.propTypes.style,
    cancelStyle: viewPropTypes.style,
    cancelTextStyle: Text.propTypes.style,
    overlayStyle: viewPropTypes.style,
    cancelText: PropTypes.string
};

@mikaello
Copy link

That's the same approach as the fork react-native-modal-selector has taken.

@recs182
Copy link

recs182 commented Jan 30, 2018

I switched to rc-modal-selector since my only problem was this repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants