-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup plugin #2
base: main
Are you sure you want to change the base?
Setup plugin #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
Tested using vim-plug and NeoVim v0.7.2.
call plug#begin()
Plug 'vsherratt/cylc.vim', {'branch': 'setup-plugin'}
call plug#end()
Opened a PR to update the docs to point at this plugin: cylc/cylc-doc#624 |
Sorry I totally left this hanging - just reminded by recent prompts for people to get set up with cylc 8. I didn't realise how long it had been! I'll address the existing comments shortly, and have a look for if the original syntax file has moved on at all. (Unless you're already aware of any changes and can easily point them out?) |
No probs, thanks for contributing this. Apologies, my vim script abilities aren't good enough to help out properly. Not much has happened to the syntax file in the Cylc repo, main changes:
|
I'll try to do a quick review too once you're done @vsherratt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this!
Otherwise, use your favourite plugin manager, such as | ||
[pathogen.vim](https://github.com/tpope/vim-pathogen). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pathogen seems a bit dead looking (note on the project saying not to use it).
Possibly replace with vim-plug:
Otherwise, use your favourite plugin manager, such as | |
[pathogen.vim](https://github.com/tpope/vim-pathogen). | |
Otherwise, use your favourite plugin manager, such as | |
[vim-plug](https://github.com/junegunn/vim-plug): | |
`Plug 'cylc/cylc.vim'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note on pathogen is not because it's dead per se, it's because its behaviour is so close to vim 8's package management that you might as well use that. That's what I like it for: it backports that functionality. Could still make more sense to mention vim-plug than that, not sure...
Initial setup of a plugin
ftdetect/cylc.vim
syntax/cylc.vim
cylcMultiString
for triple-quoted strings, which is linked toString
, unlike single-quoted strings which are not highlighed at allftplugin/cylc.vim
(for:filetype plugin
)indent/cylc.vim
(for:filetype indent
)Check List
CONTRIBUTING.md
and added my name as a Code Contributor.