Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check global config for hub url and #507

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

markgrahamdawson
Copy link
Contributor

@markgrahamdawson markgrahamdawson commented Sep 15, 2023

Closes #238

Uses hub url in global config (see cylc/cylc-flow#5733)
Existing testing needed to work with and without the global config parameter set - monkey patch used to change settings.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present). NA
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch. NA

@markgrahamdawson markgrahamdawson self-assigned this Sep 15, 2023
CHANGES.md Outdated Show resolved Hide resolved
cylc/uiserver/scripts/gui.py Outdated Show resolved Hide resolved
cylc/uiserver/scripts/gui.py Outdated Show resolved Hide resolved
cylc/uiserver/scripts/gui.py Outdated Show resolved Hide resolved
cylc/uiserver/scripts/gui.py Outdated Show resolved Hide resolved
cylc/uiserver/scripts/gui.py Outdated Show resolved Hide resolved
cylc/uiserver/scripts/gui.py Outdated Show resolved Hide resolved
cylc/uiserver/tests/test_gui.py Outdated Show resolved Hide resolved
cylc/uiserver/tests/test_gui.py Outdated Show resolved Hide resolved
@wxtim wxtim added this to the 1.5.0 milestone Sep 21, 2023
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (b043bb9) 75.31% compared to head (09b47ae) 75.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   75.31%   75.42%   +0.10%     
==========================================
  Files          12       12              
  Lines        1422     1428       +6     
  Branches      235      236       +1     
==========================================
+ Hits         1071     1077       +6     
  Misses        301      301              
  Partials       50       50              
Files Changed Coverage Δ
cylc/uiserver/scripts/gui.py 89.47% <100.00%> (+0.90%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliver-sanders oliver-sanders merged commit 1433411 into cylc:master Sep 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hub: the gui command should open the hub URL when configured
4 participants