-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check global config for hub url and #507
Merged
oliver-sanders
merged 6 commits into
cylc:master
from
markgrahamdawson:feature-global-hub-url
Sep 22, 2023
Merged
check global config for hub url and #507
oliver-sanders
merged 6 commits into
cylc:master
from
markgrahamdawson:feature-global-hub-url
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
wxtim
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
wxtim
reviewed
Sep 21, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 75.31% 75.42% +0.10%
==========================================
Files 12 12
Lines 1422 1428 +6
Branches 235 236 +1
==========================================
+ Hits 1071 1077 +6
Misses 301 301
Partials 50 50
☔ View full report in Codecov by Sentry. |
oliver-sanders
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238
Uses hub url in global config (see cylc/cylc-flow#5733)
Existing testing needed to work with and without the global config parameter set - monkey patch used to change settings.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present). NACHANGES.md
entry included if this is a change that can affect users?.?.x
branch. NA