Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to access cylc play --upgrade. #490

Closed
wants to merge 1 commit into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Sep 4, 2023

Final thing to close #429

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Manually tested.
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX. No docs
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim self-assigned this Sep 4, 2023
@wxtim wxtim added the small label Sep 4, 2023
@wxtim wxtim added this to the 1.4.0 milestone Sep 4, 2023
@wxtim wxtim force-pushed the feature.upgrade_available_in_GUI branch from 7345030 to 68804b9 Compare September 4, 2023 09:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (ad4ccc6) 75.42% compared to head (68804b9) 75.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   75.42%   75.44%   +0.01%     
==========================================
  Files          12       12              
  Lines        1408     1409       +1     
  Branches      234      234              
==========================================
+ Hits         1062     1063       +1     
  Misses        296      296              
  Partials       50       50              
Files Changed Coverage Δ
cylc/uiserver/schema.py 71.01% <100.00%> (+0.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MetRonnie
Copy link
Member

Wasn't this already done in #455?

@wxtim
Copy link
Member Author

wxtim commented Sep 4, 2023

Wasn't this already done in #455?

Yes. I've become confused because it wasn't synced to Master yet.

@wxtim wxtim closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

play: add --upgrade option
3 participants