-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jupyter lab dashboard link #1982
jupyter lab dashboard link #1982
Conversation
7616464
to
f01c5d6
Compare
f01c5d6
to
827b95a
Compare
The jupyterlab stops being disabled when I have done the pip install jupyterlab and I have cylc/cylc-uiserver#641 checked out. But when I click it it goes to the noAuth page |
Can you open Jupyter Lab by changing the URL from |
(@wxtim, use |
|
||
/** | ||
* SVG icons for use in the Cylc UI: | ||
* - Centralise icons for use throughout multiple components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve - It'd be nicer if the tooltip didn't give you the "jupyterlab is not installed" message when it is, but the UIS version is wrong, but shouldn't block this feature IMO.
If you can think of an easy way to do it, do so, else merge?
</v-list-item-subtitle> | ||
</v-list-item> | ||
<v-tooltip :disabled="user.extensions?.lab"> | ||
Jupyter Lab is not installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no way of telling without modifying the UIS PR providing this data whether ?.lab
is missing because it's not installed, or becuase user
hasn't been endowed with that data is there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can think of an easy way to do it, do so, else merge?
The easy way is to bundle this with an appropriate UIS version so that this situation never occurs.
Requires cylc/cylc-uiserver#641
To review:
cylc gui
and insepecting the Dashboard page (unless you have installed Jupyter lab) the link should be disabled.pip install jupyterlab
) and re-run thecylc gui
, then follow the link on the Dashboard page.Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.