Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter lab dashboard link #1982

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 1, 2024

Requires cylc/cylc-uiserver#641

To review:

  • Try running cylc gui and insepecting the Dashboard page (unless you have installed Jupyter lab) the link should be disabled.
  • Try installing Jupyter Lab (pip install jupyterlab) and re-run the cylc gui, then follow the link on the Dashboard page.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@markgrahamdawson
Copy link
Contributor

markgrahamdawson commented Nov 8, 2024

The jupyterlab stops being disabled when I have done the pip install jupyterlab and I have cylc/cylc-uiserver#641 checked out.
image

But when I click it it goes to the noAuth page

@oliver-sanders
Copy link
Member Author

But when I click it it goes to the noAuth page

Can you open Jupyter Lab by changing the URL from /cylc/# to /lab?

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Nov 11, 2024

(@wxtim, use build or build:watch to test, but not serve as this isn't set up for multi-extension access)


/**
* SVG icons for use in the Cylc UI:
* - Centralise icons for use throughout multiple components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve - It'd be nicer if the tooltip didn't give you the "jupyterlab is not installed" message when it is, but the UIS version is wrong, but shouldn't block this feature IMO.

If you can think of an easy way to do it, do so, else merge?

</v-list-item-subtitle>
</v-list-item>
<v-tooltip :disabled="user.extensions?.lab">
Jupyter Lab is not installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no way of telling without modifying the UIS PR providing this data whether ?.lab is missing because it's not installed, or becuase user hasn't been endowed with that data is there?

Copy link
Member Author

@oliver-sanders oliver-sanders Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can think of an easy way to do it, do so, else merge?

The easy way is to bundle this with an appropriate UIS version so that this situation never occurs.

@oliver-sanders oliver-sanders merged commit 26a857c into cylc:master Nov 15, 2024
7 of 8 checks passed
@oliver-sanders oliver-sanders deleted the add-jupyterlab-button branch November 15, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants