Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency graphql to v16 #1022

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 13, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
graphql ~15.8.0 -> ~16.6.0 age adoption passing confidence

Release Notes

graphql/graphql-js

v16.6.0

Compare Source

v16.6.0 (2022-08-16)

New Feature 🚀
Bug Fix 🐞
Committers: 2

v16.5.0

Compare Source

v16.5.0 (2022-05-09)
New Feature 🚀
Committers: 1

v16.4.0

Compare Source

v16.4.0 (2022-04-25)
New Feature 🚀
Bug Fix 🐞
Docs 📝
2 PRs were merged
Polish 💅
3 PRs were merged
Internal 🏠
26 PRs were merged
Dependency 📦
2 PRs were merged
Committers: 7

v16.3.0

Compare Source

v16.3.0 (2022-01-26)
New Feature 🚀
Bug Fix 🐞
Docs 📝
2 PRs were merged
Polish 💅
7 PRs were merged
Internal 🏠
5 PRs were merged
Dependency 📦
4 PRs were merged
Committers: 6

v16.2.0: v16.2.0

Compare Source

v16.2.0 (2021-12-17)

New Feature 🚀
Docs 📝
Polish 💅
Internal 🏠
2 PRs were merged
Committers: 2

v16.1.0

Compare Source

v16.1.0 (2021-12-07)

New Feature 🚀
Bug Fix 🐞
Docs 📝
Polish 💅
9 PRs were merged
Internal 🏠
9 PRs were merged
Dependency 📦
4 PRs were merged
Committers: 5

v16.0.1

Compare Source

v16.0.1 (2021-11-01)

Bug Fix 🐞
Polish 💅
Internal 🏠
Committers: 1

v16.0.0

Compare Source

v16.0.0 (2021-10-28)
Breaking Change 💥
Deprecation ⚠
New Feature 🚀
Bug Fix 🐞
Docs 📝
5 PRs were merged
Polish 💅
119 PRs were merged

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@MetRonnie MetRonnie added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 13, 2022
@MetRonnie MetRonnie marked this pull request as draft May 25, 2022 15:57
@MetRonnie
Copy link
Member

MetRonnie commented May 25, 2022

Don't know if addressing #1028 would fix the test failures

@AaronDCole
Copy link
Contributor

Ive extensively investigated this issue and I don't think its feasible to update at this point.

The update to GraphQL v16 wont work as is because the dependency on "https://github.com/apollographql/graphql-tag" is out of date, and the replacement using createSchema (built into graphql) wont work ether as we haven't properly defined definitions for Delta, Added, Updated and Workflow (and possibly more I didn't catch), or Bruno did somehow but the definitions are not tripping the SLD validation library.

Unfortunately updating the subscription-transport-ws library didn't seem to have any impact, and I cant investigate further while the invalid AST error persists (which wont go away unless we replace the gql library we are using with the updated graphql v16 one, breaking the validation library.

@hjoliver
Copy link
Member

Ouch, so how do we get this unblocked, in due course?

@renovate renovate bot changed the title fix(deps): update dependency graphql to v16 Update dependency graphql to v16 Sep 27, 2022
@renovate renovate bot changed the title Update dependency graphql to v16 fix(deps): update dependency graphql to v16 Dec 20, 2022
@renovate renovate bot changed the title fix(deps): update dependency graphql to v16 fix(deps): update dependency graphql to v16 - autoclosed Jan 4, 2023
@renovate renovate bot closed this Jan 4, 2023
@renovate renovate bot deleted the renovate/graphql-16.x branch January 4, 2023 09:23
@renovate renovate bot changed the title fix(deps): update dependency graphql to v16 - autoclosed fix(deps): update dependency graphql to v16 Jan 4, 2023
@renovate renovate bot reopened this Jan 4, 2023
@renovate renovate bot restored the renovate/graphql-16.x branch January 4, 2023 10:13
@renovate renovate bot force-pushed the renovate/graphql-16.x branch 2 times, most recently from 3decd1b to 0acceff Compare January 24, 2023 01:06
@renovate renovate bot force-pushed the renovate/graphql-16.x branch 2 times, most recently from ebe3862 to 70880e9 Compare January 27, 2023 02:07
@renovate renovate bot force-pushed the renovate/graphql-16.x branch 4 times, most recently from 43ba9ba to 3b9a88d Compare February 20, 2023 14:14
@renovate renovate bot force-pushed the renovate/graphql-16.x branch 5 times, most recently from 4e1f893 to 454df12 Compare February 28, 2023 12:58
@renovate renovate bot force-pushed the renovate/graphql-16.x branch 2 times, most recently from e32e897 to 9db8d6e Compare April 2, 2023 22:34
@renovate renovate bot force-pushed the renovate/graphql-16.x branch 3 times, most recently from 674e0f7 to 5e720d3 Compare May 2, 2023 23:06
@renovate renovate bot force-pushed the renovate/graphql-16.x branch 4 times, most recently from 8339dd6 to 886d722 Compare May 18, 2023 15:26
@MetRonnie MetRonnie added this to the 2.x milestone May 19, 2023
@MetRonnie
Copy link
Member

Tests are passing now? 🤷‍♂️

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested out with real Cylc workflows and everything seems to work. Don't know if the problems previously faced were Webpack related, but it seems fine with Vue 3 / Vite.

@MetRonnie MetRonnie marked this pull request as ready for review May 19, 2023 14:42
@MetRonnie MetRonnie modified the milestones: 2.x, 2.0.0 May 19, 2023
@hjoliver
Copy link
Member

OK, seems to work for me too.

@hjoliver hjoliver merged commit 846f292 into master May 23, 2023
@hjoliver hjoliver deleted the renovate/graphql-16.x branch May 23, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants