Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when set-severity receives invalid logging level #3353

Merged
merged 2 commits into from
Sep 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/cylc-set-verbosity
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def main(parser, options, suite, severity_str):
try:
severity = LOGGING_LVL_OF[severity_str]
except KeyError:
parser.error("Illegal logging level, %s" % severity)
parser.error("Illegal logging level, %s" % severity_str)

prompt("Set logging level to %s in %s" % (severity_str, suite),
options.force)
Expand Down
25 changes: 25 additions & 0 deletions tests/cli/03-set-verbosity.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#!/bin/bash
# THIS FILE IS PART OF THE CYLC SUITE ENGINE.
# Copyright (C) 2008-2019 NIWA & British Crown (Met Office) & Contributors.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#-------------------------------------------------------------------------------
# Test "cylc set-verbosity" with a bad verbosity level.
. "$(dirname "$0")/test_header"
set_test_number 2
run_fail "${TEST_NAME_BASE}" cylc set-verbosity duck quack
contains_ok "${TEST_NAME_BASE}.stderr" <<'__ERR__'
cylc-set-verbosity: error: Illegal logging level, quack
__ERR__
exit