Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schema modifiers as mutable #75

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Use schema modifiers as mutable #75

merged 7 commits into from
Jul 10, 2024

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Jul 10, 2024

🔍 What was changed

Call modifier's withRole() method at the same moment when they are added into Entity definition.
An exception will be thrown when a modifier is added to an entity without role

🤔 Why?

To not to rewrite all the stateful behaviors

📝 Checklist

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (8fbc463) to head (e618563).

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x      #75   +/-   ##
=========================================
  Coverage     94.90%   94.90%           
  Complexity      590      590           
=========================================
  Files            45       45           
  Lines          1667     1669    +2     
=========================================
+ Hits           1582     1584    +2     
  Misses           85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk changed the title Allow mutable schema modifiers Use schema modifiers as mutable Jul 10, 2024
@roxblnfk roxblnfk merged commit 413af8f into 2.x Jul 10, 2024
40 of 41 checks passed
@roxblnfk roxblnfk deleted the modifiers-clones branch July 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Bug type:feature New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 All the behaviors must be stateless
3 participants