Avoid opening popups and tooltips as new windows as a workaround to f…

…ix a display issue with AUs on Apple silicon
cvde · Apr 15, 2022 · 19fa674 · 19fa674
1 parent c603cc3
commit 19fa674
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/Source/LookAndFeel/CustomLookAndFeel.cpp b/Source/LookAndFeel/CustomLookAndFeel.cpp
@@ -40,10 +40,11 @@ namespace LookAndFeelHelpers
 }
 }
 
-CustomLookAndFeel::CustomLookAndFeel()
+CustomLookAndFeel::CustomLookAndFeel(juce::Component& tlc)
+    : topLevelComponent(tlc)
 {
     defaultFont = juce::Typeface::createSystemTypefaceFor(BinaryData::OpenSansCondensedBold_ttf, BinaryData::OpenSansCondensedBold_ttfSize);
-    LookAndFeel::getDefaultLookAndFeel().setDefaultSansSerifTypeface(defaultFont.getTypefacePtr());
+    setDefaultSansSerifTypeface(defaultFont.getTypefacePtr());
 
     setColour(juce::ResizableWindow::ColourIds::backgroundColourId, juce::Colour(0xff5e5e5e));
     setColour(juce::DocumentWindow::textColourId, juce::Colours::white);
@@ -66,6 +67,12 @@ CustomLookAndFeel::CustomLookAndFeel()
     setColour(juce::TextEditor::backgroundColourId, juce::Colour(0xff5e5e5e));
 }
 
+// draw tooltips and menus directly into the editor window (https://forum.juce.com/t/bug-popup-menu-background-and-logic-silicon/43243/10)
+juce::Component* CustomLookAndFeel::getParentComponentForMenuOptions (const juce::PopupMenu::Options&)
+{
+    return &topLevelComponent;
+}
+
 // change size of slider textbox
 juce::Slider::SliderLayout CustomLookAndFeel::getSliderLayout (juce::Slider& slider)
 {

diff --git a/Source/LookAndFeel/CustomLookAndFeel.h b/Source/LookAndFeel/CustomLookAndFeel.h
@@ -24,7 +24,9 @@
 class CustomLookAndFeel : public juce::LookAndFeel_V4
 {
 public:
-    CustomLookAndFeel();
+    explicit CustomLookAndFeel(juce::Component&);
+
+    juce::Component* getParentComponentForMenuOptions (const juce::PopupMenu::Options&) override;
 
     juce::Slider::SliderLayout getSliderLayout (juce::Slider&) override;
     void drawLinearSlider (juce::Graphics&, int x, int y, int width, int height,
@@ -59,6 +61,7 @@ class CustomLookAndFeel : public juce::LookAndFeel_V4
 
 private:
     juce::Font defaultFont;
+    juce::Component& topLevelComponent;
 
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(CustomLookAndFeel)
 };
diff --git a/Source/PluginEditor.cpp b/Source/PluginEditor.cpp
@@ -25,11 +25,13 @@ ReverbAudioProcessorEditor::ReverbAudioProcessorEditor(
     juce::ValueTree& appStateTree)
         : AudioProcessorEditor(&processor),
           applicationState(appStateTree),
+          customLookAndFeel(*this),
           headerSection(processor, parameterTree, aboutDialog),
           outputSection(parameterTree),
           earlySection(parameterTree),
           lateSection(parameterTree)
 {
+    juce::LookAndFeel::setDefaultLookAndFeel(&customLookAndFeel);
     setLookAndFeel(&customLookAndFeel);
     headerSection.setLookAndFeel(&customLookAndFeel);
     outputSection.setLookAndFeel(&customLookAndFeel);

diff --git a/Source/PluginEditor.h b/Source/PluginEditor.h
@@ -48,7 +48,7 @@ class ReverbAudioProcessorEditor : public juce::AudioProcessorEditor
     AboutDialog aboutDialog;
 
     // make tooltips visible
-    juce::TooltipWindow tooltipWindow{nullptr, 300};
+    juce::TooltipWindow tooltipWindow{this, 300};
 
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR(ReverbAudioProcessorEditor)
 };