Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beatGroups in 5/4, 6/4, 7/4, 9/4, 12/4 #260

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

vanderstel
Copy link
Member

This PR removes a code block that was causing 5/4, 6/4, 7/4, 9/4, and 12/4 to create triple beat subdivisions:

Previous:

const ts = new music21.meter.TimeSignature('6/4');
console.log(ts.computeBeatGroups());
>>> [[3, 8], [3, 8], [3, 8], [3, 8]]

Current:

const ts = new music21.meter.TimeSignature('6/4');
console.log(ts.computeBeatGroups());
>>> [[2, 8]]

Copy link
Member

@mscuthbert mscuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- I will be moving the rest of music21p meter code here, but it will take some time. This is a much better interim step.

@mscuthbert mscuthbert merged commit 1c4420d into master Aug 21, 2024
2 checks passed
@mscuthbert mscuthbert deleted the fix-beat-groups branch August 21, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants