Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyproject updates #1741

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Pyproject updates #1741

merged 2 commits into from
Oct 30, 2024

Conversation

jacobtylerwalls
Copy link
Member

Congrats on the release! Spotted these potential additions while approving a PR from a conda bot to package 9.3 for conda.

Thanks for shout out in the docs! Spotted an "o" in my middle name, but decided to just skip the whole word, since I don't really go by that anywhere but gmail and my url, although I may need to in the future to disambiguate me from the other Jacob Walls on spotify...

@coveralls
Copy link

Coverage Status

coverage: 93.026% (-0.001%) from 93.027%
when pulling 3e4a909 on pyproject-updates
into d030776 on master.

@mscuthbert
Copy link
Member

OOOPS! So sorry -- Something looked wrong about the middle name to me too -- I was like "there's no "a" between t and y" I even looked up in two places that there was no Tayl... -- and somehow my spider sense didn't tell me "look at the second syllable you dolt!" Good to know that we're not using it anyhow!.

@mscuthbert mscuthbert merged commit 1dfb6d0 into master Oct 30, 2024
8 checks passed
@mscuthbert
Copy link
Member

Will Conda need a new 9.3.1 release to get the correct packaging?

@mscuthbert mscuthbert deleted the pyproject-updates branch October 30, 2024 20:18
@jacobtylerwalls
Copy link
Member Author

no worries!

Will Conda need a new 9.3.1 release to get the correct packaging?

nah, I added the <2.0.0 for numpy in the conda PR, and the rest is only helpful for people browsing/querying pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants