Make _dissonanceScore independent of octaves
#1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cuthbertLab#1689 where the spelling of a pitch was dependent on its octave.
float3
added a commit
to float3/tuningplayground
that referenced
this pull request
Mar 13, 2024
|
I'm not sure I agree with this approach. Dissonances are generally more tolerated in higher pitches than lower pitches. If we're going to need to place a dissonance somewhere I'd generally place it higher. Is there a test that shows an improvement with this method? |
|
closing and reopening to update lint. |
|
Ah, thanks -- sorry that I missed this. Yes, that definitely is a problem -- no way that Gb is the right spelling for a single note in Am. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1689 where the spelling of a pitch was dependent on its octave.
This was a result of the _dissonanceScore computing Pythagorean ratios between the keyContext (which contributes a Pitch without Octave), and the given pitches. Now, the ratios are always computed between Pitches without Octaves to ensure correct scoring.
Adds a regression test and code simplifications as well.