Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide Change - Union types #1679

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Styleguide Change - Union types #1679

merged 3 commits into from
Jan 3, 2024

Conversation

mscuthbert
Copy link
Member

From now on, music21 prefers (but does not enforce) no space around union type operator: |

Seeing this usage as becoming standard in Python, as it is in typescript.

Has to disable for a couple of set unions as well, but worth it.

Been working on other projects and this seems so much more natural.

Lack of space is not enforced, which is good for complex types.

From now on, music21 prefers (but does not enforce) no space around union type operator: `|`
@coveralls
Copy link

coveralls commented Jan 3, 2024

Coverage Status

coverage: 93.038%. remained the same
when pulling f2a2f73 on flake8-typing
into eab94f1 on master.

@mscuthbert mscuthbert merged commit 72120cc into master Jan 3, 2024
7 checks passed
@mscuthbert mscuthbert deleted the flake8-typing branch January 3, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants