Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1633 #1636

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #1633 #1636

wants to merge 4 commits into from

Commits on Aug 20, 2023

  1. Fix music21 <forward> tag parsing 

    No longer create hidden rests while parsing forward tags in musicXML files, as this led to problems.
If there are unfilled gaps, they will be filled later by makeRests anyways if required.
    @TimFelixBeyer
    TimFelixBeyer authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    de901e6 View commit details
    Browse the repository at this point in the history

  2. Remove incorrectly added rests 

    Inspired by cuthbertLab#991
    @TimFelixBeyer
    TimFelixBeyer authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    b217557 View commit details
    Browse the repository at this point in the history

  3. lint

    @TimFelixBeyer
    TimFelixBeyer authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    88871e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Correctly deal with hidden rests and XML <forward> 

    We simply wait until staves have been separated before creating rests.
testHiddenRestImpliedVoice is modified since we no longer import
the empty forward tag as a trailing duration.
    @TimFelixBeyer
    TimFelixBeyer committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    273e9b1 View commit details
    Browse the repository at this point in the history