III-6257-Sort the days of the opening hours #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhande
requested review from
simon-debruijn,
brampauwelyn and
Anahkiasen
as code owners
simon-debruijn
requested changes
Oct 14, 2024
| @@ -145,11 +145,15 @@ const CalendarOpeninghoursModal = ({ | |||
| idToChange: string, | |||
| ) => { | |||
| const checked = event.target.checked; | |||
| const daysOrder = Object.values(DaysOfWeek); | |||
There was a problem hiding this comment.
We cannot rely on the order of the values from an object.
It may work now, but it may not work at some point according to the js spec.
keys and values in an object don't maintain a certain order, because they use a hashmap datastructure behind the scenes.
Since the codebase only uses the values anyways, never specific days we can refactor the DaysOfWeek to this:
const DaysOfWeek = [
'monday',
'tuesday',
'wednesday',
'thursday',
'friday',
'saturday',
'sunday',
] as const;
type DayOfWeek = (typeof DaysOfWeek)[number];Arrays do maintain their order of elements
Comment on lines
154
to
156
| openingHour.dayOfWeek.sort((a, b) => { | ||
| return daysOrder.indexOf(a) - daysOrder.indexOf(b); | ||
| }); |
There was a problem hiding this comment.
With the change above this becomes
Suggested change
| openingHour.dayOfWeek.sort((a, b) => { | |
| return daysOrder.indexOf(a) - daysOrder.indexOf(b); | |
| }); | |
| openingHour.dayOfWeek.sort((a, b) => { | |
| return DaysOfWeek.indexOf(a) - DaysOfWeek.indexOf(b); | |
| }); |
simon-debruijn
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Ticket: https://jira.uitdatabank.be/browse/III-6257