Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags from Examples to Scenario Outline (#164) #165

Merged
merged 8 commits into from
Dec 1, 2021
Merged

Add tags from Examples to Scenario Outline (#164) #165

merged 8 commits into from
Dec 1, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Nov 18, 2021 •
edited by tyranron
Loading

Part of #164

Synopsis

See #164

Solution

Add tags from Examples to Scenario Outline

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added bug Something isn't working enhancement Improvement of existing features or bugfix labels Nov 18, 2021
@ilslv ilslv added this to the 0.11 milestone Nov 18, 2021
@ilslv ilslv self-assigned this Nov 18, 2021
@ilslv
Copy link
Member Author

ilslv commented Nov 18, 2021

FCM

Add tags from `Examples` to `Scenario Outline` (#165, #164)

@ilslv ilslv requested review from tyranron and removed request for tyranron November 18, 2021 06:26
@ilslv
Copy link
Member Author

ilslv commented Nov 18, 2021

@tyranron let's wait until cucumber-rs/gherkin#29 is merged and only then merge this one with new version of gherkin-rust. Test-suit in this repo is more robust, that gherkin-rust, as we compare resulting ASTs.

@tyranron tyranron removed the bug Something isn't working label Nov 18, 2021
@ilslv ilslv requested a review from tyranron December 1, 2021 06:08
@tyranron tyranron merged commit ae2c9ee into main Dec 1, 2021
@tyranron tyranron deleted the 164-add-tags-from-examples branch December 1, 2021 10:07
@tyranron tyranron mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron