Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for url params from url regexp capture groups #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ifrim
Copy link

@ifrim ifrim commented Apr 20, 2021

This PR adds support for url params taken from named capture groups of regex urls.

Below is an example of mocking a request to /api/foo/1/bar/2 where we need some data from the url.
Before:

mock.onGet(/\/api\/foo\/[^/]+\/bar\/[^?/]+$/).reply(function (config) {
  let { fooId, barId } = config.url.match(/\/api\/foo\/(?<fooId>[^/]+)\/bar\/(?<barId>[^?/]+)$/).groups;
  console.log(fooId, barId); // 1, 2
  return [200];
});

After:

mock.onGet(/\/api\/foo\/(?<fooId>[^/]+)\/bar\/(?<barId>[^?/]+)$/).reply(function (config) {
  let { fooId, barId } = config.urlParams;
  console.log(fooId, barId); // 1, 2
  return [200];
});

This allows us to define the data we want from the url and to have it available in the reply function without having to duplicate the same (or similar) regex to extract the data.

Notes

If there is anything that needs to be changed in this PR I am happy to do it.

This can be an alternative and an easy win for #205.

@kennethbruskiewicz
Copy link

I would appreciate this feature as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants