feat: add c api #62
Draft
feat: add c api #62
+964
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 12 12
Lines 233 233
Branches 26 26
=======================================
Hits 221 221
Misses 7 7
Partials 5 5 ☔ View full report in Codecov by Sentry. |
cthulhu-irl
force-pushed
the
61-add-c-api
branch
4 times, most recently
from
284577b
to
e7c54bf
Compare
cthulhu-irl
force-pushed
the
61-add-c-api
branch
2 times, most recently
from
a79dd59
to
e1d898a
Compare
| return parsi_charset_t{ .bitset = { bytes[0], bytes[1], bytes[2], bytes[3] } }; | ||
| } | ||
|
|
||
| parsi_parser_t* parsi_alloc_parser(parsi_parser_t parser) |
There was a problem hiding this comment.
The std::malloc call could fail, returning nullptr. It's good practice to check if malloc was successful before using the pointer.
issue #61
cthulhu-irl
force-pushed
the
61-add-c-api
branch
from
e1d898a
to
cf8f694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #61