-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effective Area 3D #281
Effective Area 3D #281
Conversation
…ensions The different methods use binning in different coordinate systems - effective_area_3D_polar uses a polar coordinate system with radial FOV offset and azimuthal FOV position angle bins - effective_area_3D_nominal uses a nominal coordinate system with FOV longitude and FOV latitude bins
These calculate the number of showers in each bin for different coordinate systems - calculate_n_showers_3D_polar uses a polar coordinate system with radial FOV offset bins and azimuthal FOV position angle bins - calculate_n_showers_3D_nominal uses a nominal coordinate system with FOV longitude and latitude bins
…into effective_area_3d
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 95.60% 95.01% -0.60%
==========================================
Files 62 62
Lines 3278 3308 +30
==========================================
+ Hits 3134 3143 +9
- Misses 144 165 +21 ☔ View full report in Codecov by Sentry. |
Adds two methods of calculating the effective area in bins of energy and two spacial dimensions. These methods differ in the coordinate frame used for the spacial dimensions.
calculate_effective_area_3d_polar
uses a polar coordinate system with FOV pointing position offset and position angle coordinatescalculate_effective_area_3d_nominal
uses a quasi-cartesian coordinate system with FOV longitude and latitude coordinates centred on the pointing positionAlso adds respective functions to calculate the number of showers expected in the 3D bins from simulation info to the SimulatedEventsInfo class (
calculate_n_showers_3d_polar
,calculate_n_showers_3d_nominal
), as well as a utility function to calculate the position angle w.r.t. the pointing from an event table (calculate_source_fov_position_angle
).