Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic facilities for 3D background irfs #276

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Add basic facilities for 3D background irfs #276

wants to merge 52 commits into from

Commits on Jan 16, 2024

  1. Add basic facilities for 3D background irfs

    @Tobychev
    Tobychev committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8042e5b View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. :x

    @Tobychev
    Tobychev committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5c5bded View commit details
    Browse the repository at this point in the history

  2. Should now support rectangular arrays

    @Tobychev
    Tobychev committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7c6d158 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Remove compatibility pins

    @maxnoe
    maxnoe committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2990605 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Merge pull request #283 from cta-observatory/gammapy_pin 

    Remove compatibility pins
    @maxnoe
    maxnoe authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c7db045 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Add 2023 ICRC paper to README

    @RuneDominik
    RuneDominik committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    17a7514 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #284 from cta-observatory/Readme 

    Add 2023 ICRC paper to README
    @maxnoe
    maxnoe authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8c48951 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Add basic facilities for 3D background irfs

    @Tobychev
    Tobychev committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ec66690 View commit details
    Browse the repository at this point in the history

  2. Should now support rectangular arrays

    @Tobychev
    Tobychev committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6d41197 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'refs/remotes/origin/background3d' into … 

    …background3d
    @Tobychev
    Tobychev committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    084a2b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Fixes requested by Max, added test

    @Tobychev
    Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7fc4c74 View commit details
    Browse the repository at this point in the history

  2. Add tests for more correct handling of fill-values in RadMaxEstimator

    @RuneDominik @Tobychev
    RuneDominik authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a3325f3 View commit details
    Browse the repository at this point in the history

  3. Add more correct handling of fill-values in RadMaxEstimator

    @RuneDominik @Tobychev
    RuneDominik authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0b3e177 View commit details
    Browse the repository at this point in the history

  4. Add newsfragment

    @RuneDominik @Tobychev
    RuneDominik authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7d8f79f View commit details
    Browse the repository at this point in the history

  5. adress comments

    @RuneDominik @Tobychev
    RuneDominik authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    211f712 View commit details
    Browse the repository at this point in the history

  6. Render changelog for 0.11

    @maxnoe @Tobychev
    maxnoe authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a46b73a View commit details
    Browse the repository at this point in the history

  7. Make things compatible with numpy 2.0; replace deprecated logging.warn()

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1682914 View commit details
    Browse the repository at this point in the history

  8. Add changelog entry

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    dd68f06 View commit details
    Browse the repository at this point in the history

  9. Update .mailmap

    @HealthyPear @Tobychev
    HealthyPear authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fa5af1f View commit details
    Browse the repository at this point in the history

  10. Add option of multiple quantiles to angular_resolution

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0803c77 View commit details
    Browse the repository at this point in the history

  11. No mutable default argument; check for sequence, not list and np.ndarray

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    254c4c1 View commit details
    Browse the repository at this point in the history

  12. Do not change column naming based on number of quantiles

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    592c4c6 View commit details
    Browse the repository at this point in the history

  13. Fix docs warning

    @maxnoe @Tobychev
    maxnoe authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    38fff11 View commit details
    Browse the repository at this point in the history

  14. Address comments

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b80d8fb View commit details
    Browse the repository at this point in the history

  15. Call np.nanquantile with multiple quantiles

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fe9e478 View commit details
    Browse the repository at this point in the history

  16. Rename and update changelog

    @LukasBeiske @Tobychev
    LukasBeiske authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    01fb541 View commit details
    Browse the repository at this point in the history

  17. Add 2 methods to calculate effective area in energy and 2 spacial dim… 

    …ensions

The different methods use binning in different coordinate systems
 - effective_area_3D_polar uses a polar coordinate system with radial FOV offset and azimuthal FOV position angle bins
 - effective_area_3D_nominal uses a nominal coordinate system with FOV longitude and FOV latitude bins
    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    84fda49 View commit details
    Browse the repository at this point in the history

  18. Add methods to calculate n_showers in energy and 2 spacial dimensions 

    These calculate the number of showers in each bin for different coordinate systems
 - calculate_n_showers_3D_polar uses a polar coordinate system with radial FOV offset bins and azimuthal FOV position angle bins
 - calculate_n_showers_3D_nominal uses a nominal coordinate system with FOV longitude and latitude bins
    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    68c3fa6 View commit details
    Browse the repository at this point in the history

  19. Add util for calculating FOV position angle

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    242ecab View commit details
    Browse the repository at this point in the history

  20. Fix effective_area_3d and poition angle util

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    50d8002 View commit details
    Browse the repository at this point in the history

  21. Fix missing comma

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6547e22 View commit details
    Browse the repository at this point in the history

  22. Fix typos causing error when calling calculate_n_showers_3d_*

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b43c0aa View commit details
    Browse the repository at this point in the history

  23. Remove redundant argument breaking calculate_n_showers_3d call

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a7c5a9a View commit details
    Browse the repository at this point in the history

  24. Fix formatting and issues from pull request Effective Area 3D (no. 28… 

    …1) code review
    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e033135 View commit details
    Browse the repository at this point in the history

  25. Add functions to transform from sky coordinates to FOV coordinates

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    cb58e41 View commit details
    Browse the repository at this point in the history

  26. Update calculate_n_showers_3d functions and add tests

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2ec0a19 View commit details
    Browse the repository at this point in the history

  27. Fix position angle function, add rectangle solid angle function and t… 

    …ests
    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4674679 View commit details
    Browse the repository at this point in the history

  28. Update effective area 3D functions and add corresponding tests

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5e38254 View commit details
    Browse the repository at this point in the history

  29. Fix code review issues

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8e017c5 View commit details
    Browse the repository at this point in the history

  30. Update function names in __all__

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2a91a87 View commit details
    Browse the repository at this point in the history

  31. Fix all changed occurences of gadf coordinate function calls

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b516419 View commit details
    Browse the repository at this point in the history

  32. Change az/alt to lon/lat due to support of both AltAz and ICRS

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e18e1ae View commit details
    Browse the repository at this point in the history

  33. Add newsfragment

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3162c4a View commit details
    Browse the repository at this point in the history

  34. Properly handle viewcone_min > 0, add docstring

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8cd0e75 View commit details
    Browse the repository at this point in the history

  35. Add missing condition to all_outside check

    @Tobychev
    Luca Di Bella authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    82b60b3 View commit details
    Browse the repository at this point in the history

  36. Update energy_dispersion_to_migration 

    Remove stale debugging code

Add news fragment

Update energy_dispersion_to_migration

- divide by the migration bin widths before resampling
- minor style and format changes

Fix pdf conversion to probability,  remove final norm
    @HealthyPear @Tobychev
    HealthyPear authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a63a56b View commit details
    Browse the repository at this point in the history

  37. Add function to compute energy migration matrix from events 

    Simplify normalization code for migra matrix
    @HealthyPear @Tobychev
    HealthyPear authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f3b4d04 View commit details
    Browse the repository at this point in the history

  38. Add unit test for energy migration matrix from events 

    update unit test
    @HealthyPear @Tobychev
    HealthyPear authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7f2d45d View commit details
    Browse the repository at this point in the history

  39. Update test_energy_dispersion_to_migration 

    Fix test_energy_dispersion_to_migration
    @HealthyPear @Tobychev
    HealthyPear authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2bd128c View commit details
    Browse the repository at this point in the history

  40. fix: docstring irf.energy_dispersion.energy_migration_matrix

    @HealthyPear @Tobychev
    HealthyPear authored and Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4bc8f57 View commit details
    Browse the repository at this point in the history

  41. Add basic facilities for 3D background irfs

    @Tobychev
    Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    82e2035 View commit details
    Browse the repository at this point in the history

  42. Fixes

    @Tobychev
    Tobychev committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    03b9626 View commit details
    Browse the repository at this point in the history