Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/benchmarks #183

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Mar 29, 2022

Fixing/improving a few benchmark notebooks

  • MODEL/classification: added plots showing energy and impact distributions for gammas/protons

- PrecisionRecallDisplay crashed due to bins with no data
- re-ran black and isort to reformat all cells
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #183 (019314f) into master (1f392ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   63.05%   63.05%           
=======================================
  Files          28       28           
  Lines        2885     2885           
=======================================
  Hits         1819     1819           
  Misses       1066     1066           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f392ea...019314f. Read the comment docs.

@HealthyPear HealthyPear added fix A PR that fixes a bug or a wrong behaviour. benchmarks labels Apr 23, 2022
@HealthyPear HealthyPear added this to the v0.5.1 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks fix A PR that fixes a bug or a wrong behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants