Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In_out_versions #252

Merged
merged 10 commits into from
Sep 17, 2024
Merged

In_out_versions #252

merged 10 commits into from
Sep 17, 2024

Conversation

Elisa-Visentin
Copy link
Collaborator

Add the possibility to use, for each step, input data processed with an older MCP version wrt the current one

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (f4b775e) to head (40bb433).
Report is 11 commits behind head on auto_MCP_DL2_DL3.

Additional details and impacted files
@@                Coverage Diff                @@
##           auto_MCP_DL2_DL3     #252   +/-   ##
=================================================
  Coverage             77.23%   77.23%           
=================================================
  Files                    21       21           
  Lines                  2614     2614           
=================================================
  Hits                   2019     2019           
  Misses                  595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsitarek
Copy link
Collaborator

I checked the files and the changes look ok. Once a test is run we should also check the job_accounting script if it is not missing any input files because they are in a different folder

@Elisa-Visentin
Copy link
Collaborator Author

I am still testing it (IT queues are a bit stuck) but I will check both output and, as you suggested, job_accounting. Hopefully during the we...

@Elisa-Visentin
Copy link
Collaborator Author

Actually there was a small issue with directories (I have to create the directory with the current version name to be able to store the config. file for stereo and coincidence, or the scripts cannot read it). Now it should be fixed

@Elisa-Visentin
Copy link
Collaborator Author

Elisa-Visentin commented Sep 16, 2024

As for job accounting, I plan to fix and check it today :)

Edit: seems fine!

@Elisa-Visentin Elisa-Visentin marked this pull request as ready for review September 16, 2024 09:04
@jsitarek
Copy link
Collaborator

looks good, shall we merge?

@Elisa-Visentin
Copy link
Collaborator Author

For me, yes (I finished all the tests and job accounting is fine)

@jsitarek jsitarek merged commit 38ff6b5 into auto_MCP_DL2_DL3 Sep 17, 2024
8 checks passed
@jsitarek jsitarek deleted the v_in_out branch September 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants