Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tel id from config.yaml #248

Merged
merged 6 commits into from
Aug 13, 2024
Merged

use tel id from config.yaml #248

merged 6 commits into from
Aug 13, 2024

Conversation

Elisa-Visentin
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (40d483d) to head (1f3e8dc).

Additional details and impacted files
@@               Coverage Diff                @@
##           Torino_auto_MCP     #248   +/-   ##
================================================
  Coverage            77.23%   77.23%           
================================================
  Files                   21       21           
  Lines                 2614     2614           
================================================
  Hits                  2019     2019           
  Misses                 595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsitarek
Copy link
Collaborator

I think you also need to update the readme file:

The file `config_auto_MCP.yaml` must contain the telescope IDs, the directories with the MC data (ignored if you set NSB_matching = true), the data selection, and some information on the night sky background (NSB) level and software versions:

@Elisa-Visentin
Copy link
Collaborator Author

I updated the readme in the 'no_MC' PR (since some of the lines to be updated are the same, this way there should be no conflicts)

@jsitarek jsitarek merged commit 81482b8 into Torino_auto_MCP Aug 13, 2024
8 checks passed
@jsitarek jsitarek deleted the fix-telid branch August 13, 2024 12:18
@aleberti aleberti added the maintenance Maintenance related label Aug 14, 2024
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants