Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-automatic scripts on the last MCP version #217

Merged
merged 292 commits into from
Aug 14, 2024
Merged

Conversation

Elisa-Visentin
Copy link
Collaborator

@Elisa-Visentin Elisa-Visentin commented Mar 25, 2024

Update of #170 (which was too old wrt master). Comments in the old PR will be considered here

Authors: Elisa, Federico, Joanna, Julian, Raniere

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (5f9d88e) to head (0dc34e1).
Report is 293 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   77.23%   77.23%           
=======================================
  Files          21       21           
  Lines        2614     2614           
=======================================
  Hits         2019     2019           
  Misses        595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Elisa-Visentin
Copy link
Collaborator Author

Elisa-Visentin commented Mar 28, 2024

Comments from the old PR (closed)

  • nsb_level: logger.warning or logger.error if len(list_bash_scripts)<1

  • MC file for NSB

  • lstchain config for nsb

  • error len(LST_files)>1: needed?

  • setting_up: if len(all_file)==0: error message

  • general: config files

@Elisa-Visentin
Copy link
Collaborator Author

Elisa-Visentin commented Apr 28, 2024

The last committed scripts can be used to create an LST-run-wise database. Here its structure
image
nsb column hosts NSB level (for 0.10 data, if both versions exist), lstchain_0.9 and lstchain_0.10 columns will host a bool value (i.e., True if version 0.9/0.10 for this run exists. STILL TO BE FILLED), error_code is nan in case of good runs, 000 in case NSB cannot be evaluated, 001 in case NSB > 3.0
Suggestions? What about this structure?

@Elisa-Visentin Elisa-Visentin dismissed aleberti’s stale review August 14, 2024 10:02

all the comments are implemented

@jsitarek jsitarek merged commit fc68ae6 into master Aug 14, 2024
8 checks passed
@jsitarek jsitarek deleted the Torino_auto_MCP branch August 14, 2024 10:53
@aleberti aleberti added the new functionality For new functionalities label Aug 14, 2024
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Semi-automatic scripts on the last MCP version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new functionality For new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants