Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the history of the time offset between LST-1 and MAGIC #150

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

SeiyaNozaki
Copy link
Collaborator

After WRS re-synchronization, the time offset between LST-1 and MAGIC was changed to -6.2 us.
This PR just updated the history comment in the script and config file.

@aleberti aleberti self-requested a review September 19, 2023 21:04
@aleberti aleberti merged commit a559456 into master Sep 19, 2023
0 of 2 checks passed
@aleberti aleberti deleted the update_time_offset_log branch September 19, 2023 21:31
@jsitarek
Copy link
Collaborator

thank you @SeiyaNozaki for the update and @aleberti for approving and merging it.
However, if we need to update this part again, since those are just comments, and the values are needed only for a sanity check in the new coincidence scheme, maybe it is enough to include them only in one place instead of two (config file and the coincidence script)

@SeiyaNozaki
Copy link
Collaborator Author

Now I'm thinking of adding another file somewhere describing pre-defined values depending on the run number or timestamp. Then, if pre offset search fails to find the possible candidate (or pre_offset_search is deactivated), it will use the pre-defined values. Do you agree? Then, we don't need to add corresponding lines to config file or header part of the coincidence script every power cycle. Just we need to add this info to this file and analyzer doesn't need to care about the values too much.

@aleberti aleberti added the maintenance Maintenance related label Nov 2, 2023
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
Update the history of the time offset between LST-1 and MAGIC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants