Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Irf maker and cut optimiser #2473

Draft
wants to merge 158 commits into
base: main
Choose a base branch
from
Draft

Irf maker and cut optimiser #2473

wants to merge 158 commits into from

Commits on Sep 30, 2024

  1. First kludge of protopipe irf code as a ctapipe tool

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2f09bd4 View commit details
    Browse the repository at this point in the history

  2. Fixed names so the tool can install properly

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bff9c19 View commit details
    Browse the repository at this point in the history

  3. Fixing two small comments from Karl

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3033d69 View commit details
    Browse the repository at this point in the history

  4. Various small fixes

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f65b13b View commit details
    Browse the repository at this point in the history

  5. Big refactor to use components as intended

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6505d73 View commit details
    Browse the repository at this point in the history

  6. Got it all to run

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ad3bc6b View commit details
    Browse the repository at this point in the history

  7. Formatting fixes

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    26633c4 View commit details
    Browse the repository at this point in the history

  8. Adjusting defaults to make only one bin in offset?

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0f4f143 View commit details
    Browse the repository at this point in the history

  9. Moved preselection to start()

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2908d71 View commit details
    Browse the repository at this point in the history

  10. Use only one true energy axis

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    52149cf View commit details
    Browse the repository at this point in the history

  11. Use only one true energy axis

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0add49d View commit details
    Browse the repository at this point in the history

  12. Use only one true energy axis

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    760b67a View commit details
    Browse the repository at this point in the history

  13. Refactoring to group things in the same manner

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3879a0c View commit details
    Browse the repository at this point in the history

  14. Split preselct into remaning and quality selecting, made EventPreProc… 

    …essor a quality query
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c94d44c View commit details
    Browse the repository at this point in the history

  15. Fixed serveral problems

    @LukasBeiske
    Tomas Bylund authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    87a8853 View commit details
    Browse the repository at this point in the history

  16. Fixed unit issue

    @LukasBeiske
    Tomas Bylund authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    628bc89 View commit details
    Browse the repository at this point in the history

  17. Updated some defaults

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7764fe6 View commit details
    Browse the repository at this point in the history

  18. Updated some comments to avoid problems with the doctest

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cb7c29e View commit details
    Browse the repository at this point in the history

  19. Add changelog

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2ef1257 View commit details
    Browse the repository at this point in the history

  20. Fixed small bug, trying to pass doctests

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e20f863 View commit details
    Browse the repository at this point in the history

  21. Refactored after feedback

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b4f5f08 View commit details
    Browse the repository at this point in the history

  22. Refactored after feedback

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6525d19 View commit details
    Browse the repository at this point in the history

  23. Refactored after feedback

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e892475 View commit details
    Browse the repository at this point in the history

  24. Made spectra into enums

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    41a7cf4 View commit details
    Browse the repository at this point in the history

  25. Added specific configuration of the optimisation grid to the cut opti… 

    …miser component
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e58f5b6 View commit details
    Browse the repository at this point in the history

  26. Refactored based on feedback: new tests that simulations stay consist… 

    …ent and some renaming
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    03382f8 View commit details
    Browse the repository at this point in the history

  27. Refactored based on feedback: cleaner test

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e415ea6 View commit details
    Browse the repository at this point in the history

  28. Various changes to match reference script.

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f7b95f3 View commit details
    Browse the repository at this point in the history

  29. Reworked how initial theta cuts are calculated, changed some logging … 

    …printouts
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    249f0df View commit details
    Browse the repository at this point in the history

  30. Update conf.py 

    copy Max's fix to the doc config to ignore traitlets things.
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a76b8a2 View commit details
    Browse the repository at this point in the history

  31. Moved PSF related quantities into its own component

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6b1176a View commit details
    Browse the repository at this point in the history

  32. Renamed PSF component to ThetaCutsCalculator, other small refactors

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e4fca2d View commit details
    Browse the repository at this point in the history

  33. Update to support newest pyirf version

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8c773be View commit details
    Browse the repository at this point in the history

  34. Fix logging error

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bc0769d View commit details
    Browse the repository at this point in the history

  35. Use consistent offset binning

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    db8a12c View commit details
    Browse the repository at this point in the history

  36. Add theta cut to the background, change logging statments

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9572ea8 View commit details
    Browse the repository at this point in the history

  37. Partial refactoring into optimising and calculating parts

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3679a1c View commit details
    Browse the repository at this point in the history

  38. Mayor refactor complete, still not running properly

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e7e7298 View commit details
    Browse the repository at this point in the history

  39. Various changes to get the code to run end to end

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    51fe469 View commit details
    Browse the repository at this point in the history

  40. Pretty large refactoring around how results are saved, cleaned out so… 

    …me not purely irf tables from the output
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    62f4c7e View commit details
    Browse the repository at this point in the history

  41. Further refactoring to decouple things now that there are two tools

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ed1773e View commit details
    Browse the repository at this point in the history

  42. Added background and benchmarking option to the make_irf tool

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b1d726a View commit details
    Browse the repository at this point in the history

  43. removed some dead code that had been left behind by mistake

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    eca4857 View commit details
    Browse the repository at this point in the history

  44. Minor fixes

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3e0217a View commit details
    Browse the repository at this point in the history

  45. Ensure users requested binning is honoured

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    aaad809 View commit details
    Browse the repository at this point in the history

  46. Fixed typo in EXTNAME of energy dispersion

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    42aff5e View commit details
    Browse the repository at this point in the history

  47. Add several convenience functions for plotting irfs

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2082251 View commit details
    Browse the repository at this point in the history

  48. Added function to draw 2d hist from a irf table

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f10029c View commit details
    Browse the repository at this point in the history

  49. Use integar indices for fov bounds; fix write out of benchmark hdus

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2dedab8 View commit details
    Browse the repository at this point in the history

  50. Remove redundant overwrite flag

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7e732be View commit details
    Browse the repository at this point in the history

  51. Add some aliases and flags; fix logging bug

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6e9e668 View commit details
    Browse the repository at this point in the history

  52. Rename some files and classes

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a3ab016 View commit details
    Browse the repository at this point in the history

  53. Make EventPreProcessor a subcomponent of EventsLoader

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    76e2ac6 View commit details
    Browse the repository at this point in the history

  54. Use reco energy for rad_max table

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9d728d5 View commit details
    Browse the repository at this point in the history

  55. Use n_bins everywhere instead of n_edges

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3be1f7d View commit details
    Browse the repository at this point in the history

  56. Add reco bins to logging; remove unused bins

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b4fe396 View commit details
    Browse the repository at this point in the history

  57. Fix EventPreProcessor configurability

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ddfff51 View commit details
    Browse the repository at this point in the history

  58. Make ThetaCutsCalculator configurable

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e4ed8d5 View commit details
    Browse the repository at this point in the history

  59. Fix help for n_bins config options

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    66d2e6a View commit details
    Browse the repository at this point in the history

  60. Added helper function for plotting just bin-wise statistics of IRF ta… 

    …bles
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5542f10 View commit details
    Browse the repository at this point in the history

  61. Added energy binning directly to the PsfIrf class

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    846dcd4 View commit details
    Browse the repository at this point in the history

  62. Created a Background2D and Background3D IRF classes

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    859679f View commit details
    Browse the repository at this point in the history

  63. Add option for point-like IRF; support diffuse and point-like gammas

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0ae4522 View commit details
    Browse the repository at this point in the history

  64. Update to consistently use number of bins

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2cd26eb View commit details
    Browse the repository at this point in the history

  65. Added calculation of fov_lat/lon and explicit column descriptions

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    19bd342 View commit details
    Browse the repository at this point in the history

  66. Added a bit of logging

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    847c1a0 View commit details
    Browse the repository at this point in the history

  67. Remove unnecessary conversions

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ea023bf View commit details
    Browse the repository at this point in the history

  68. Moved stuff to match src/ organisatoin

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dcc148e View commit details
    Browse the repository at this point in the history

  69. Fix extra dimension in effective area per offset, adapt to new loader… 

    … syntax
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    197a15a View commit details
    Browse the repository at this point in the history

  70. Fixed bug where background only used gh-cuts

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    272f8c9 View commit details
    Browse the repository at this point in the history

  71. Renamed some options for clarity

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d8dddd1 View commit details
    Browse the repository at this point in the history

  72. Clarified arguments for full-enclosure irfs

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bcb39af View commit details
    Browse the repository at this point in the history

  73. Sort and remove duplicates in sphinx nitpicks

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1d94a93 View commit details
    Browse the repository at this point in the history

  74. Use AstroQuantity trait for observation time

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7bccc19 View commit details
    Browse the repository at this point in the history

  75. Add definition of selectable spectra to irf.select

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    63ab23e View commit details
    Browse the repository at this point in the history

  76. Force same clf for computation and application of g/h cuts; warn if o… 

    …verwriting precuts in irf-tool
    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1bb1b1e View commit details
    Browse the repository at this point in the history

  77. Use full-enclosure flag for cut optimization tool

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    be815c7 View commit details
    Browse the repository at this point in the history

  78. Remove theta cut re-calculation from irf-tool; move ThetaCutsCalculat… 

    …or to optimize.py; add individual binning to ThetaCutsCalculator
    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    aaae997 View commit details
    Browse the repository at this point in the history

  79. Make saving a theta cut optional in cut-opt tool and if saved, also s… 

    …ave it as RAD_MAX
    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1c9f1f0 View commit details
    Browse the repository at this point in the history

  80. Remove redundant bin range check

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    11f3227 View commit details
    Browse the repository at this point in the history

  81. Apply event selection per particle type

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e32d2ea View commit details
    Browse the repository at this point in the history

  82. More AstroQuantity

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d1ec28c View commit details
    Browse the repository at this point in the history

  83. Rework irf classes

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    85ef303 View commit details
    Browse the repository at this point in the history

  84. Make irf parameterizations configurable

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    eb6d402 View commit details
    Browse the repository at this point in the history

  85. Move spectra definition to separate file

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ec1a203 View commit details
    Browse the repository at this point in the history

  86. Revert change of edisp extname

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3e75fc3 View commit details
    Browse the repository at this point in the history

  87. Also calculate aeff for protons and electrons

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e05ade3 View commit details
    Browse the repository at this point in the history

  88. Update cut optimization components and make cut opt algorithm configu… 

    …rable
    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a3e26f8 View commit details
    Browse the repository at this point in the history

  89. Clearer class names

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ea51376 View commit details
    Browse the repository at this point in the history

  90. Remove FoVOffsetBinning; save singular quantities in ResultValidRange

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2fe7f6a View commit details
    Browse the repository at this point in the history

  91. No cut on background events based on its true origin position

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7893882 View commit details
    Browse the repository at this point in the history

  92. Split out input handling code to separate helper to keep logic of ini… 

    …t more clear
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    04896f7 View commit details
    Browse the repository at this point in the history

  93. Fixed typo

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    abeff95 View commit details
    Browse the repository at this point in the history

  94. Set min pyirf version to handle astropy 6.0

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    eb57af4 View commit details
    Browse the repository at this point in the history

  95. Create a minimal changelog

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9522253 View commit details
    Browse the repository at this point in the history

  96. Use classes_with_traits() in tools

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    44cd2dc View commit details
    Browse the repository at this point in the history

  97. cleaning up changelogs

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    09244e8 View commit details
    Browse the repository at this point in the history

  98. Added messages explaining which bin range was failing to pass the check

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    32a99bc View commit details
    Browse the repository at this point in the history

  99. Respect bounds over n_bins_per_decade for energy binning

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    952ac4a View commit details
    Browse the repository at this point in the history

  100. Made range check optionally only emit warning, made output a bit more… 

    … readable
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    09dbf33 View commit details
    Browse the repository at this point in the history

  101. Added tracking of where range check came from, made check failure opt… 

    …ionally emit warning
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ec26225 View commit details
    Browse the repository at this point in the history

  102. Discared Lukas changes in error

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7c4b7a9 View commit details
    Browse the repository at this point in the history

  103. Fixed some code quality issues from sonar

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c571a4d View commit details
    Browse the repository at this point in the history

  104. Fixed typo

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4697e65 View commit details
    Browse the repository at this point in the history

  105. Fixed problems where PSF was not always being generate

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    222d615 View commit details
    Browse the repository at this point in the history

  106. Added optional colorbar plotting to plot_hist2d, additional small fixes

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f6df242 View commit details
    Browse the repository at this point in the history

  107. Move benchmarks into dedicated Components; remove OutputEnergyBinning

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b12eb69 View commit details
    Browse the repository at this point in the history

  108. Add type hints to EventsLoader and EventPreProcessor

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    928495c View commit details
    Browse the repository at this point in the history

  109. Add fov binning for benchmarks

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    27c5aaa View commit details
    Browse the repository at this point in the history

  110. Only compute psf for full enclosure irf

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    607eda7 View commit details
    Browse the repository at this point in the history

  111. Allow user renaming of cols and check for needed cols after

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    35648a7 View commit details
    Browse the repository at this point in the history

  112. Add tests for event loading and selection code; minor bugfix

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6b5f622 View commit details
    Browse the repository at this point in the history

  113. Shorten bins in range checks a bit

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0312c25 View commit details
    Browse the repository at this point in the history

  114. Fix number of bin edges in make_bins_per_decade

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    52a0280 View commit details
    Browse the repository at this point in the history

  115. parent=None as default for all components

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f445976 View commit details
    Browse the repository at this point in the history

  116. Add tests for binning

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fbb48af View commit details
    Browse the repository at this point in the history

  117. Fix caplog binning test

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e086810 View commit details
    Browse the repository at this point in the history

  118. Do not use caplog in test, due to problems with pytest-xdist

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    40e3eb2 View commit details
    Browse the repository at this point in the history

  119. Do not expose base classes

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    877f701 View commit details
    Browse the repository at this point in the history

  120. Add missing docstring

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fb83330 View commit details
    Browse the repository at this point in the history

  121. Fix imports in binning tests

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d149b53 View commit details
    Browse the repository at this point in the history

  122. Remove wrong bin-in-range checks; fix valid_fov_offset

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e99fd25 View commit details
    Browse the repository at this point in the history

  123. Only compute event weights, if a sensitivity is computed

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    54b17ff View commit details
    Browse the repository at this point in the history

  124. Make proton and electron files optional, if PercentileCuts is used

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9fb5ebd View commit details
    Browse the repository at this point in the history

  125. Move pytest fixtures to conftest.py

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d5dd15c View commit details
    Browse the repository at this point in the history

  126. Some tests for cut optimization

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    add4f5f View commit details
    Browse the repository at this point in the history

  127. Fixed hardcoded nonsensical offset bins for RAD_MAX

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0a35a00 View commit details
    Browse the repository at this point in the history

  128. Add test to ensure BackgroundRate2dMaker stays working once current r… 

    …egression is fixed
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    470d7d8 View commit details
    Browse the repository at this point in the history

  129. Fixed broken background generation

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    251c210 View commit details
    Browse the repository at this point in the history

  130. Rework event weight calculation

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    73a8839 View commit details
    Browse the repository at this point in the history

  131. Fix background2D test

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    388797c View commit details
    Browse the repository at this point in the history

  132. More tests for optimization components

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8b66fb9 View commit details
    Browse the repository at this point in the history

  133. Iterate over cut optimizers in optimize tests

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    aba24ff View commit details
    Browse the repository at this point in the history

  134. Add more tests for irf makers

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bbe713a View commit details
    Browse the repository at this point in the history

  135. Small refactoring of irf tests

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b1cf941 View commit details
    Browse the repository at this point in the history

  136. Add tests for benchmarks; fix axis order in benchmark output

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cce9c7b View commit details
    Browse the repository at this point in the history

  137. Address some comments

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5d1f3ac View commit details
    Browse the repository at this point in the history

  138. replace removed in numpy 2.0

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3d4719a View commit details
    Browse the repository at this point in the history

  139. Add unit definition, docstring, fix table name

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d71f2ef View commit details
    Browse the repository at this point in the history

  140. Fixed bug with weights not being set properly

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2ea0b01 View commit details
    Browse the repository at this point in the history

  141. Make header row using columns directly

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a6726cb View commit details
    Browse the repository at this point in the history

  142. fixed conftest table generation to work around bug with dimensionless… 

    … columns
    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c2fbc1a View commit details
    Browse the repository at this point in the history

  143. Linspace to match bins from official IRFs

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    44160aa View commit details
    Browse the repository at this point in the history

  144. harmonised column names

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b2539ca View commit details
    Browse the repository at this point in the history

  145. Made linear bins optional, adjusted wording of help strings

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2e79710 View commit details
    Browse the repository at this point in the history

  146. Trying to work around pyIrf errors

    @Tobychev @LukasBeiske
    Tobychev authored and LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    23f57f3 View commit details
    Browse the repository at this point in the history

  147. Rename EnergyMigrationMaker to EnergyDispersionMaker to avoid confusion

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2e0bae2 View commit details
    Browse the repository at this point in the history

  148. Replace do_benchmarks with optional benchmark_output_path

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    79b3999 View commit details
    Browse the repository at this point in the history

  149. Fix some code smells

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    913f66f View commit details
    Browse the repository at this point in the history

  150. Use ctapipe.compat.COPY_IF_NEEDED

    @LukasBeiske
    LukasBeiske committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9ea15e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add test for cut optimization tool

    @LukasBeiske
    LukasBeiske committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e192d8c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Add test for irf tool

    @LukasBeiske
    LukasBeiske committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2936eb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Calculate full-enclosure irf by default with optional point-like flag

    @LukasBeiske
    LukasBeiske committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5d3a0fb View commit details
    Browse the repository at this point in the history

  2. Remove old todo

    @LukasBeiske
    LukasBeiske committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    62dd84c View commit details
    Browse the repository at this point in the history

  3. Merge OptimizationResult and OptimizationResultStore

    @LukasBeiske
    LukasBeiske committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ed3afb7 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Fix some docstrings

    @LukasBeiske
    LukasBeiske committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    21ec7d6 View commit details
    Browse the repository at this point in the history

  2. Remove support for non-standart column names

    @LukasBeiske
    LukasBeiske committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e7e8031 View commit details
    Browse the repository at this point in the history

  3. Move on/off ratio config to PointSourceSensitivityOptimizer

    @LukasBeiske
    LukasBeiske committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7198622 View commit details
    Browse the repository at this point in the history