Notebook for quick simulation of LST1 observations

[moralejo]

The telescope performance is stored in the csv files The background is obtained from good-quality real data, the gamma IRF from MC

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (cfd9a7f) to head (a734bd9).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files         134      134           
  Lines       14211    14211           
=======================================
  Hits        10446    10446           
  Misses       3765     3765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jsitarek]

in the "pulsar mode" field it would be safer to put the overwritting of alpha and printing of it into if pulsar_mode: clause, otherwise somebody can by mistake overwrite alpha despite having the pulsar_mode set to false
especially that later on there is a check on pulsar_mode, so the cell with pulsar_mode definition needs to be executed

[jsitarek]

in the integrate function, why not passing the dFdE function as a parameter and computing dfde1 and dfde2 inside the integrate function?

[jsitarek]

there is a typo: "jus trplace"
and later on "bind" instead of "bins"

[jsitarek]

I am not sure if it is a good idea to randomize the position of the true energies when you calculate the energy migration. If I understand the code correctly this means that from one execution to another you will have a different number of times you sample a given true energy bin, and this will shift the events back and forth. Maybe best to have the fine binning in Etrue uniform and only randomize (or also use constant fine binning) in the migration factor

[jsitarek]

As the final plot of the notebook will likely end up in many of the proposals, I would recommend to made some changes to it to unify how they look like:
increase the marker size (the middle range points for a strong source are not visible)
add some basic information that were used during the calculation into the legend of the plot (observation time, zenith angle, maybe also if pulsar mode or extension were defined)
add somewhere in the corner of the figure the version number of the macro