Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FF charge limits in data check #1305

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

moralejo
Copy link
Collaborator

@moralejo moralejo commented Oct 8, 2024

No description provided.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.51%. Comparing base (538ca80) to head (b7d5119).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/scripts/lstchain_longterm_dl1_check.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1305   +/-   ##
=======================================
  Coverage   73.51%   73.51%           
=======================================
  Files         134      134           
  Lines       14218    14218           
=======================================
  Hits        10453    10453           
  Misses       3765     3765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add a brief comment describing why this change in the expected charge, it is welcome. Otherwise, fine with me as it is.

@moralejo moralejo merged commit 6483c60 into main Oct 9, 2024
8 of 9 checks passed
@moralejo moralejo deleted the ff_q_limit_datacheck branch October 9, 2024 13:18
@moralejo moralejo restored the ff_q_limit_datacheck branch October 9, 2024 13:19
@moralejo moralejo deleted the ff_q_limit_datacheck branch October 9, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants