Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ROLIE feeds #108

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Implementation of ROLIE feeds #108

merged 6 commits into from
Nov 13, 2024

Conversation

oxisto
Copy link
Contributor

@oxisto oxisto commented Nov 12, 2024

This leverages the JSON schema from oasis-tcs/csaf#481, so extra credits belong to @tschmidtb51. This probably needs some more testing since the JSON schema does not fully implement all fields of the ROLIE RFC.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...kotlin/io/github/csaf/sbom/retrieval/CsafLoader.kt 100.00% <100.00%> (ø)
...io/github/csaf/sbom/retrieval/RetrievedProvider.kt 100.00% <100.00%> (ø)

@oxisto oxisto marked this pull request as ready for review November 12, 2024 21:25
@oxisto oxisto linked an issue Nov 12, 2024 that may be closed by this pull request
@oxisto oxisto requested a review from milux November 12, 2024 21:48
Copy link
Collaborator

@milux milux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially incomplete, e.g. document counting does not include ROLIE feeds yet.

Refactor document streaming to combine URL fetching from indices and ROLIE feeds, removing redundant channels. Updated logic to calculate expected documents and adjusted test cases to reflect the changes.
Copy link
Collaborator

@milux milux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine now.

@milux milux merged commit 14a0e40 into main Nov 13, 2024
6 checks passed
@milux milux deleted the rolie branch November 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ROLIE feeds
2 participants