Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiler versions constraints for interpreter signal handler [fixup #14766] #15178

Conversation

straight-shoota
Copy link
Member

This is a follow-up to #14766. The new primitives are only available in master
This patch ensures forward compatibility for the latest stable compiler (Crystal 1.14) and below.

It would be useful to have a macro that checks for the availability of primitives.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:system kind:regression Something that used to correctly work but no longer works topic:compiler:interpreter labels Nov 11, 2024
@straight-shoota straight-shoota self-assigned this Nov 11, 2024
@straight-shoota straight-shoota force-pushed the fix/interpreter-forward-compatibility branch from 4fb9ad0 to ad01192 Compare November 11, 2024 13:15
@straight-shoota straight-shoota force-pushed the fix/interpreter-forward-compatibility branch from e6ba3a2 to a4ef8b0 Compare November 11, 2024 20:36
@straight-shoota straight-shoota added this to the 1.15.0 milestone Nov 12, 2024
@straight-shoota straight-shoota merged commit 489cdf1 into crystal-lang:master Nov 13, 2024
69 checks passed
@straight-shoota straight-shoota deleted the fix/interpreter-forward-compatibility branch November 13, 2024 14:57
@straight-shoota straight-shoota changed the title Add compiler versions constraints for interpreter signal handler Add compiler versions constraints for interpreter signal handler [fixup #14766] Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:compiler:interpreter topic:stdlib:system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants