Add unit_separator to #humanize and #humanize_bytes

[CTC97]

Adds a separate_unit parameter to the humanize and humanize_bytes methods. If selected adds a non-breaking space ('\u00A0') between the value and the unit.

Also includes relevant specs.

Fixes #14349

[straight-shoota]

Maybe a configurable parameter could be better than a boolean flag?
This would give more flexibility and allow use cases where a different separator then a non-breaking space is needed.

[CTC97]

Maybe a configurable parameter could be better than a boolean flag?

Does it make sense to give the user full control over the separator, or should we define an enum that limits options?

[Sija]

Also, the default IMO should use a regular space for compatibility.

[straight-shoota]

What would be the reason for limiting? I don't see why any arbitrary restriction would be useful. If someone want's a particular string as separator, let them have it.

[CTC97]

Just pushed the change to allow for custom unit separators. Thought about a Char but that felt overly restrictive as well. 👍

[ysbaddaden]

Just a tiny nitpick: specs could use a Char whenever possible to demonstrate the encouraged use, use a String when there are more than one char, and just leave one check that we can pass a 1 char string (or nil, number or whatever).

[CTC97]

Just a tiny nitpick: specs could use a Char whenever possible to demonstrate the encouraged use, use a String when there are more than one char, and just leave one check that we can pass a 1 char string (or nil, number or whatever).

Good call. I cleaned up the tests and left the ones that I think are meaningful.

[ysbaddaden]

Thank you for your patience while we ironed out this feature 🙇

[CTC97]

Thank you for your patience while we ironed out this feature 🙇

Happy to! Honored to contribute. 🔮✨