set cookie expiry to unix epoch. Set cookie max_age to zero to ensure…

… browser deletion
crystal-lang · Jul 23, 2024 · 564f926 · 564f926
1 parent abe3943
commit 564f926
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/spec/std/http/cookie_spec.cr b/spec/std/http/cookie_spec.cr
@@ -76,6 +76,7 @@ module HTTP
 
       cookie.value.empty?.should be_true
       cookie.expired?.should be_true
+      cookie.max_age.should eq(Time::Span.zero)
     end
 
     describe "#name=" do

diff --git a/src/http/cookie.cr b/src/http/cookie.cr
@@ -198,7 +198,8 @@ module HTTP
     # Browsers delete cookies that have expired.
     def destroy
       self.value = ""
-      self.expires = 5.minutes.ago
+      self.expires = Time::UNIx_EPOCH
+      self.max_age = Time::Span.zero
     end
 
     # :nodoc: