Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically sync sha256 and sha3-224 from libjade upstream. #70

Closed
wants to merge 2 commits into from

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Sep 4, 2023

I formatted the python script using black.

Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the SHA256 code in libjade is unverified, as far as I know, so merging that to dev is fine but we should be careful not to include or at least expose it in main.

@franziskuskiefer
Copy link
Member

Note that the SHA256 code in libjade is unverified, as far as I know, so merging that to dev is fine but we should be careful not to include or at least expose it in main.

Please look at the code first. This is not actually using any new libjade code in libcrux.

@karthikbhargavan
Copy link
Contributor

Added an issue: #71

@franziskuskiefer franziskuskiefer added the waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2023
Copy link

This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 27, 2024
Copy link

github-actions bot commented Sep 3, 2024

This PR has been closed due to a lack of activity since being marked as stale. If you believe this pull request is still relevant, please reopen it with an update or comment.

@github-actions github-actions bot closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants