ML-KEM: AVX2 target feature edition #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
requested changes
Oct 17, 2024
Co-authored-by: Franziskus Kiefer <[email protected]>
…rux into jonas/ml-kem-target-feature
This reverts commit c56dd15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step of addressing #633.
It should get us most of the way back to reasonable performance, e.g. on my machine the difference between a
RUSTFLAGS="-C target-feature=+avx2" cargo bench --features pre-verificationand simplycargo bench --features pre-verificationseems to be within 10-20% across keygen, encaps & decaps.So, there seem to be more things still, and I didn't particularly look at key validation, yet. But it should be a good first step, anyway.