Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import sys/libjade/build.rs from franziskus/hacl-sys branch #51

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Import sys/libjade/build.rs from franziskus/hacl-sys branch #51

merged 12 commits into from
Aug 28, 2023

Conversation

mamonet
Copy link
Member

@mamonet mamonet commented Aug 23, 2023 •
edited
Loading

The patch uses cc library to compile libjade instead of clang commands and create libcrux_platform package to detect cpu features.

@mamonet mamonet force-pushed the main branch 2 times, most recently from c661adb to 446eff2 Compare August 23, 2023 12:03
franziskuskiefer
franziskuskiefer requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good except for one issue.

sys/libjade/build.rs Outdated Show resolved Hide resolved
@franziskuskiefer franziskuskiefer linked an issue Aug 24, 2023 that may be closed by this pull request
use cc for all -sys builds #46
Closed
franziskuskiefer
franziskuskiefer requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks pretty good already. A few points inline.

Please run rustfmt on the code.

sys/libjade/Cargo.toml Outdated Show resolved Hide resolved
sys/platform/src/lib.rs Show resolved Hide resolved
sys/platform/src/lib.rs Show resolved Hide resolved
franziskuskiefer
franziskuskiefer reviewed Aug 25, 2023
View reviewed changes
sys/platform/src/test.rs Outdated Show resolved Hide resolved
sys/platform/src/test.rs Outdated Show resolved Hide resolved
sys/platform/src/test.rs Show resolved Hide resolved
franziskuskiefer
franziskuskiefer requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few more things, then we can get this in.

A comment on the workflow: Never force push on a branch that is in a PR. This breaks the review workflow. (Generally, force pushing is bad practice.)

sys/platform/src/x86.rs Outdated Show resolved Hide resolved
sys/platform/src/lib.rs Outdated Show resolved Hide resolved
sys/platform/src/lib.rs Outdated Show resolved Hide resolved
sys/platform/src/lib.rs Show resolved Hide resolved
sys/platform/src/linux_arm.rs Outdated Show resolved Hide resolved
sys/platform/src/test.rs Show resolved Hide resolved
sys/platform/src/test.rs Show resolved Hide resolved
sys/platform/src/test.rs Show resolved Hide resolved
sys/platform/src/linux_arm.rs Outdated Show resolved Hide resolved
sys/platform/src/lib.rs Show resolved Hide resolved
@franziskuskiefer franziskuskiefer mentioned this pull request Aug 28, 2023
Merged
franziskuskiefer
franziskuskiefer approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in.

@franziskuskiefer franziskuskiefer merged commit 416c56f into cryspen:main Aug 28, 2023
3 checks passed
franziskuskiefer pushed a commit that referenced this pull request Aug 28, 2023
@mamonet @franziskuskiefer
Use cc to build libjade and add platform detection crate (#51)
1b26692
@mamonet mamonet mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees

@mamonet mamonet

Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use cc for all -sys builds
2 participants
@mamonet @franziskuskiefer