Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added derandomized kyber to libjade-sys. #23

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Added derandomized kyber to libjade-sys. #23

merged 6 commits into from
Aug 1, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Jul 31, 2023

No description provided.

@xvzcf xvzcf force-pushed the add-libjade-kyber branch 2 times, most recently from e92f01a to 01111fd Compare August 1, 2023 14:56
franziskuskiefer
franziskuskiefer approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

There are two follow ups

  • add the avx2 version
  • add kats for kyber on the top level

But lets get this in with the comments addressed.

src/jasmin.rs Outdated Show resolved Hide resolved
src/digest.rs Show resolved Hide resolved
@franziskuskiefer franziskuskiefer mentioned this pull request Jul 3, 2023
Closed
2 tasks
@franziskuskiefer franziskuskiefer enabled auto-merge (squash) August 1, 2023 17:11
@franziskuskiefer franziskuskiefer merged commit 1a1e207 into main Aug 1, 2023
3 checks passed
@franziskuskiefer franziskuskiefer deleted the add-libjade-kyber branch August 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvzcf @franziskuskiefer